All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy MacLeod <randy.macleod@windriver.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH] opencv: disable broken Intel FP16 detection
Date: Wed, 26 Apr 2017 21:45:18 -0400	[thread overview]
Message-ID: <877a46e7-4b93-64ea-762b-40b00a552930@windriver.com> (raw)
In-Reply-To: <20170427013329.7827-1-Randy.MacLeod@windriver.com>

On 2017-04-26 09:33 PM, Randy MacLeod wrote:
> With opencv-3.2, the configuration detects if the target supports
> half-precision floating-point format. This fails to compile for some
> Intel targets such as skylake with an error such as:
>    error: '_mm_cvtph_ps' was not declared in this scope
>
> The configuration worked in opencv-3.1 so revert two commits to
> drop the FP16 detection even though it may make opencv slower.
> The only change in the configure log is:
> --- FP16: Compiler support is available
> +-- FP16: Compiler support is not available
>
> The patch should be dropped when a newer version of opencv that includes commit:
>    https://github.com/opencv/opencv/commit/e5d9b608c47d54e43496041595025fa282fa9de5
> is available. Backporting that fix was involved many files and
> a cherry-picking explosion so it's not worthwhile.
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---

I'm not particularly happy with this patch but it does fix
a build problem and doesn't appear to break any arches.
It's probably best if I soak it on our build cluster and
that I take a more time to confirm that I haven't broken anything.

I'm off work until Monday now so I thought that some people on the list
might be interested in the patch or in pitching in. If not, I'll
follow up next week.

Btw, I'm pinging the opencv devs to see when the next release is
expected.

-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5


  reply	other threads:[~2017-04-27  1:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27  1:33 [meta-oe][PATCH] opencv: disable broken Intel FP16 detection Randy MacLeod
2017-04-27  1:45 ` Randy MacLeod [this message]
2017-05-02 14:57 ` Randy MacLeod
2017-05-02 15:51   ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877a46e7-4b93-64ea-762b-40b00a552930@windriver.com \
    --to=randy.macleod@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.