From: Markus Armbruster <armbru@pond.sub.org>
To: Jag Raman <jag.raman@oracle.com>
Cc: "Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: x-remote-object breaks QOM introspection
Date: Thu, 19 Nov 2026 07:07:17 +0100 [thread overview]
Message-ID: <877bi9e4mi.fsf@pond.sub.org> (raw)
In-Reply-To: <E30ADD82-0779-4294-B235-D27FD379C9D6@oracle.com> (Jag Raman's message of "Wed, 18 Nov 2026 15:27:46 +0000")
Jag Raman <jag.raman@oracle.com> writes:
>> On Nov 17, 2026, at 9:58 AM, Markus Armbruster <armbru@pond.sub.org> wrote:
>>
>> Watch this:
>>
>> $ qemu-system-x86_64 -S -nodefaults -display none -qmp stdio
>> {"QMP": {"version": {"qemu": {"micro": 90, "minor": 1, "major": 11}, "package": "v11.2.0-rc0-3-g38171f59ccb-dirty"}, "capabilities": ["oob"]}}
>> {"execute": "qmp_capabilities", "arguments": {"enable": ["oob"]}}
>> {"return": {}}
>> {"execute": "qom-list-properties", "arguments": {"typename": "x-remote-object"}}
>> --> qemu-system-x86_64: (null) is not a PCI device
>> {"return": [{"name": "type", "type": "string", "qapi-type": "str"}, {"name": "devid", "type": "string", "qapi-type": "str"}, {"name": "fd", "type": "string", "qapi-type": "str"}]}
>>
>> The error message is suspicious. Origin:
>>
>> static void remote_object_machine_done(Notifier *notifier, void *data)
>> {
>> RemoteObject *o = container_of(notifier, RemoteObject, machine_done);
>> DeviceState *dev = NULL;
>> QIOChannel *ioc = NULL;
>> Coroutine *co = NULL;
>> RemoteCommDev *comdev = NULL;
>> Error *err = NULL;
>>
>> dev = qdev_find_recursive(sysbus_get_default(), o->devid);
>> if (!dev || !object_dynamic_cast(OBJECT(dev), TYPE_PCI_DEVICE)) {
>> error_report("%s is not a PCI device", o->devid);
>> return;
>> }
>>
>> o->devid is null, dev is null.
>>
>> Glibc's %s shows null pointer as "(null)". There are libcs that simply
>> crash.
>>
>> Stack backtrace:
>>
>> #0 remote_object_machine_done (notifier=0x5555587d17e8, data=0x0)
>> at ../hw/remote/remote-obj.c:93
>> #1 0x000055555578700e in qemu_add_machine_init_done_notifier
>> (notify=0x5555587d17e8) at ../hw/core/machine.c:1721
>> #2 0x00005555556f26dd in remote_object_init (obj=0x5555587d17c0)
>> at ../hw/remote/remote-obj.c:149
>> #3 0x0000555555cbda2d in object_init_with_type
>> (obj=0x5555587d17c0, ti=0x5555577c02d0) at ../qom/object.c:430
>> #4 0x0000555555cbde2c in object_initialize_with_type
>> (obj=0x5555587d17c0, size=136, type=0x5555577c02d0) at ../qom/object.c:512
>> #5 0x0000555555cbe6fa in object_new_with_type (type=0x5555577c02d0)
>> at ../qom/object.c:710
>> #6 0x0000555555cbe784 in object_new
>> (typename=0x555558356a10 "x-remote-object") at ../qom/object.c:726
>> #7 0x0000555555e2d6be in qmp_qom_list_properties
>> (typename=0x555558356a10 "x-remote-object", errp=0x7fffffffd888)
>> at ../qom/qom-qmp-cmds.c:290
>> [...]
>>
>> I believe using qemu_add_machine_init_done_notifier() is wrong here.
>> Could we use UserCreatableClass method complete()?
>
> Hi Markus,
>
> The remote_object_machine_done() notifier exists so qdev_find_recursive()
> has a chance to find o->devid. We could setup this notifier UserCreatableClass
> method complete() if you prefer.
I guess that unbreaks QOM introspection, because complete() doesn't run
there.
Can you explain why you need to defer code to machine init done?
> I think remote_object_machine_done() should return early if o->devid is
> NULL. Would you like me to make this change?
Should devid be a QOM link instead?
> Thank you,
> Jag
>
>>
>> Aside: we should probably check all uses of
>> qemu_add_machine_init_done_notifier().
next prev parent reply other threads:[~2026-11-19 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:58 x-remote-object breaks QOM introspection Markus Armbruster
2026-11-18 15:27 ` Jag Raman
2026-11-19 6:07 ` Markus Armbruster [this message]
2026-11-19 16:13 ` Jag Raman
2026-11-19 16:25 ` Daniel P. Berrangé
2026-11-20 5:21 ` Markus Armbruster
2026-11-20 8:53 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bi9e4mi.fsf@pond.sub.org \
--to=armbru@pond.sub.org \
--cc=berrange@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=pbonzini@redhat.com \
--cc=philmd@mailo.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.