All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses
Date: Sun, 15 Nov 2026 20:50:39 +0200	[thread overview]
Message-ID: <877biedj40.fsf@tarshish> (raw)
In-Reply-To: <20261115174621.3986836-1-bernd@kuhls.net> (Bernd Kuhls's message of "Sun, 15 Nov 2026 18:46:21 +0100")

Hi Bernd,

Thanks for the patch.

One question below.

On Sun, Nov 15 2026, Bernd Kuhls wrote:
> Buildroot commit aa5e3eec6384cb73d902a4de3fffc279683ea5a5 bumped the
> package to 7.0 which includes upstream commit
> https://github.com/strace/strace/commit/19642150d613312dc4bed27695a83320dcd5133e
> that adds optional support for ncurses.
>
> There is no configure option to disable ncurses support so we need to
> use ac_cv_search_tgetnum=no.
>
> Configure during runtime test finds ncurses:
> checking for termcap.h... yes
> checking for library containing tgetnum... -lncurses

Do you have an idea how this symbol test found ncurses in CI test?

baruch

> Configure log with this patch:
> checking for termcap.h... yes
> checking for library containing tgetnum... (cached) no
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/18033158691
>
> [BRTEST# strace --version
> strace: error while loading shared libraries: libncurses.so.6: cannot
>  open shared object file: No such file or directory
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/strace/strace.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/package/strace/strace.mk b/package/strace/strace.mk
> index 8eadb7eba4..97f2ddb6e5 100644
> --- a/package/strace/strace.mk
> +++ b/package/strace/strace.mk
> @@ -19,6 +19,12 @@ else
>  STRACE_CONF_OPTS += --without-libunwind
>  endif
>  
> +ifeq ($(BR2_PACKAGE_NCURSES),y)
> +STRACE_DEPENDENCIES += ncurses
> +else
> +STRACE_CONF_OPTS += ac_cv_search_tgetnum=no
> +endif
> +
>  # Demangling symbols in stack trace needs libunwind and libiberty.
>  ifeq ($(BR2_PACKAGE_BINUTILS)$(BR2_PACKAGE_LIBUNWIND),yy)
>  STRACE_DEPENDENCIES += binutils

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-11-15 18:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 17:46 [Buildroot] [PATCH 1/1] package/strace: add optional dependency to ncurses Bernd Kuhls
2026-11-15 18:50 ` Baruch Siach via buildroot [this message]
     [not found] ` <877biedj40.fsf__35447.6860187546$1794768661$gmane$org@tarshish>
2026-11-15 19:31   ` Bernd Kuhls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877biedj40.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=bernd@kuhls.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.