All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: Fabiano Rosas <farosas@suse.de>,
	 Laurent Vivier <lvivier@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/qtest: Increase the timeout of the device-introspect-test
Date: Mon, 26 Oct 2026 13:35:25 +0000	[thread overview]
Message-ID: <877bj460v6.fsf@draig.linaro.org> (raw)
In-Reply-To: <ffdb16f1-7a5a-487e-a9d6-74767ee399b8@redhat.com> (Thomas Huth's message of "Mon, 26 Oct 2026 12:30:51 +0100")

Thomas Huth <thuth@redhat.com> writes:

> On 26/10/2026 12.04, Alex Bennée wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>> 
>>> I'm occasionally seeing timeouts of the device-introspect-test for
>>> the aarch64 target when running "make check SPEED=thorough" - looks
>>> like the 720 seconds aren't enough anymore nowadays. Add 2 more
>>> minutes to give some more headroom.
>> What is taking so long, I can run all the introspect builds in under
>> 10
>> seconds:
>>    ➜  time ./run meson test --suite qtest "*device-introspect*"
>
> You've got to run the tests in slow/thorough mode:
>
> G_TEST_SLOW=1 time ./run meson test --suite qtest "*device-introspect*"
>
> otherwise a lot of the tests will be skipped and the tests will finish
> fast.

Thanks for that. I did a run to look at the profile but:

   0.81%  qemu-system-aar  [.] object_property_iter_next                                                                                                                      
   0.40%  qemu-system-aar  [.] qdict_next                                                                                                                                     
   0.36%  qemu-system-aar  [.] qdict_destroy_obj                                                                                                                              
   0.35%  IO mon_iothread  [.] object_dynamic_cast_assert                                                                                                                     
   0.27%  qemu-system-aar  [.] object_unref                                                                                                                                   
   0.24%  qemu-system-aar  [.] monitor_puts_locked                                                                                                                            
   0.24%  qemu-system-aar  [.] quoted_str                                                                                                                                     
   0.22%  IO mon_iothread  [.] json_lexer_feed_char                                                                                                                           
   0.22%  IO mon_iothread  [.] qio_channel_socket_readv                                                                                                                       
   0.21%  IO mon_iothread  [.] timerlist_deadline_ns                                                                                                                          
   0.21%  qemu-system-aar  [.] phys_page_compact                                                                                                                              
   0.19%  IO mon_iothread  [.] aio_ctx_check                                                                                                                                  
   0.18%  qemu-system-aar  [.] phys_page_set_level                                                                                                                            
   0.18%  IO mon_iothread  [.] timerlistgroup_deadline_ns                                                                                                                     
   0.16%  IO mon_iothread  [.] aio_ctx_prepare                                                                                                                                
   0.14%  IO mon_iothread  [.] tcp_chr_recv                                                                                                                                   
   0.13%  IO mon_iothread  [.] qemu_lockcnt_cmpxchg_or_wait                                                                                                                   
   0.12%  IO mon_iothread  [.] tcp_chr_read                                                                                                                                   
   0.12%  qemu-system-aar  [.] mod_utf8_codepoint                                                                                                                             
   0.11%  qemu-system-aar  [.] object_class_property_find                                                                                                                     
   0.09%  qemu-system-aar  [.] render_memory_region                                                                                                                           
   0.09%  qemu-system-aar  [.] register_subpage                                                                                                                               
   0.09%  IO mon_iothread  [.] qemu_lockcnt_dec                                                                                                                               
   0.09%  qemu-system-aar  [.] qdict_first                                                                                                                                    
   0.07%  qemu-system-aar  [.] object_initialize_with_type                                                                                                                    
   0.07%  qemu-system-aar  [.] g_hash_table_iter_next@plt                                                                                                                     
   0.06%  qemu-system-aar  [.] object_dynamic_cast_assert                                                                                                                     
   0.06%  IO mon_iothread  [.] object_class_dynamic_cast_assert  

Nothing is really jumping out at me. So much of the time seems to be
spent in the kernel:

   3.91%  IO mon_iothread  [vdso]                                        [.] __vdso_clock_gettime                                                                             
   3.68%  device-introspe  libc.so.6                                     [.] __syscall_cancel_arch                                                                            
   2.73%  qemu-system-aar  libc.so.6                                     [.] __memset_avx2_unaligned_erms                                                                     
   2.12%  IO mon_iothread  libc.so.6                                     [.] __syscall_cancel_arch                                                                            
   1.93%  device-introspe  [kernel.kallsyms]                             [k] __sys_recvfrom                                                                                   
   1.82%  device-introspe  [kernel.kallsyms]                             [k] _copy_to_iter                                                                                    
   1.70%  device-introspe  [kernel.kallsyms]                             [k] unix_stream_read_generic                                                                         
   1.67%  device-introspe  [kernel.kallsyms]                             [k] do_syscall_64                                                                                    
   1.63%  device-introspe  [kernel.kallsyms]                             [k] fdget                                                                                            
   1.55%  device-introspe  [kernel.kallsyms]                             [k] entry_SYSRETQ_unsafe_stack                                                                       
   1.36%  IO mon_iothread  [kernel.kallsyms]                             [k] entry_SYSRETQ_unsafe_stack                                                                       
   1.36%  qemu-system-aar  ld-linux-x86-64.so.2                          [.] do_lookup_x                                                                                      
   1.22%  qemu-system-aar  libglib-2.0.so.0.8400.4                       [.] g_hash_table_add                                                                                 
   1.17%  device-introspe  [kernel.kallsyms]                             [k] _raw_spin_lock                                                                                   
   1.16%  qemu-system-aar  libc.so.6                                     [.] _int_malloc                                                                                      
   1.14%  IO mon_iothread  [kernel.kallsyms]                             [k] do_syscall_64                                                                                    
   1.02%  IO mon_iothread  [kernel.kallsyms]                             [k] _copy_from_user                                                                                  
   0.99%  qemu-system-aar  libglib-2.0.so.0.8400.4                       [.] g_hash_table_iter_next                                                                           
   0.91%  device-introspe  [kernel.kallsyms]                             [k] mutex_lock                                                                                       
   0.88%  device-introspe  device-introspect-test                        [.] json_lexer_feed_char                                                                             
   0.85%  IO mon_iothread  [kernel.kallsyms]                             [k] do_sys_poll                                                                                      
   0.84%  IO mon_iothread  libglib-2.0.so.0.8400.4                       [.] 0x000000000005a7b3                                                                               
   0.81%  qemu-system-aar  qemu-system-aarch64                           [.] object_property_iter_next                                                                        
   0.81%  IO mon_iothread  libglib-2.0.so.0.8400.4                       [.] g_mutex_lock                                                                                     
   0.78%  device-introspe  [kernel.kallsyms]                             [k] fput                                                                                             
   0.77%  IO mon_iothread  [kernel.kallsyms]                             [k] fput                                                                                             
   0.71%  qemu-system-aar  libc.so.6                                     [.] malloc                                                                                           
   0.70%  device-introspe  [kernel.kallsyms]                             [k] __check_object_size                                                                              
   0.68%  meson            python3.13                                    [.] _PyEval_EvalFrameDefault                                                                         
   0.66%  IO mon_iothread  libglib-2.0.so.0.8400.4                       [.] g_source_ref                                                                                     
   0.65%  IO mon_iothread  [kernel.kallsyms]                             [k] fdget                                                                                            
   0.63%  IO mon_iothread  libglib-2.0.so.0.8400.4                       [.] g_mutex_unlock                                                                                   
   0.59%  IO mon_iothread  [kernel.kallsyms]                             [k] _copy_to_iter                                                                                    
   0.55%  device-introspe  [kernel.kallsyms]                             [k] __virt_addr_valid                                                                                
   0.53%  qemu-system-aar  libc.so.6                                     [.] _int_free_chunk                                                                                  
   0.53%  device-introspe  [kernel.kallsyms]                             [k] entry_SYSCALL_64                                                                                 
   0.51%  IO mon_iothread  [kernel.kallsyms]                             [k] fdget_pos                                                                                        
   0.48%  device-introspe  [kernel.kallsyms]                             [k] security_socket_recvmsg

which makes me wonder if there is any low-hanging fruit we could look at
in the amount of IO we are doing for the test?


>
>  Thomas

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


  reply	other threads:[~2026-10-26 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  9:23 [PATCH] tests/qtest: Increase the timeout of the device-introspect-test Thomas Huth
2026-10-26 11:04 ` Alex Bennée
2026-10-26 11:30   ` Thomas Huth
2026-10-26 13:35     ` Alex Bennée [this message]
2026-10-26 15:20     ` Alex Bennée
2026-10-26 16:00       ` Daniel P. Berrangé
2026-10-26 16:18         ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bj460v6.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=farosas@suse.de \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.