Re: [Buildroot] [PATCH v5 1/4] package/xen: fix build error when BR2_PACKAGE_XEN_TOOLS not enabled

From: Peter Korsgaard <peter@korsgaard.com>
To: Neal Frager <neal.frager@amd.com>
Cc: <buildroot@buildroot.org>,  <arnout@rnout.be>,
	<luca.ceresoli@bootlin.com>,  <thomas.petazzoni@bootlin.com>,
	<michal.simek@amd.com>,  <ju.o@free.fr>,
	 <brandon.maier@collins.com>, <romain.naour@smile.fr>,
	 <romain.naour@gmail.com>, <ibai.erkiaga-elorza@amd.com>,
	 <yann.morin@orange.com>, <alistair@alistair23.me>,
	 <brian.j.wood2@boeing.com>, <matthew.l.weber3@boeing.com>,
	 <stefano.stabellini@amd.com>, <micheal.saleab@amd.com>,
	 <stewart.hildebrand@amd.com>, <john.ernberg@actia.se>
Subject: Re: [Buildroot] [PATCH v5 1/4] package/xen: fix build error when BR2_PACKAGE_XEN_TOOLS not enabled
Date: Wed, 16 Sep 2026 08:51:25 +0200	[thread overview]
Message-ID: <877bklofiq.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260826064649.292291-1-neal.frager@amd.com> (Neal Frager's message of "Wed, 26 Aug 2026 07:46:46 +0100")

>>>>> "Neal" == Neal Frager <neal.frager@amd.com> writes:

 > The 0002-Update-linker-flags.patch assumes that the qemu-xen files are included
 > in the xen source tree. However, if BR2_PACKAGE_XEN_TOOLS is not enabled, the
 > qemu-xen dependency will not be handled and the patch will fail to apply with
 > the following error.

 > Fixes: build error below
 > Applying 0002-Update-linker-flags.patch using patch:
 > patching file tools/Makefile
 > Hunk #1 succeeded at 36 (offset -1 lines).
 > Hunk #2 succeeded at 185 (offset -8 lines).
 > can't find file to patch at input line 76
 > Perhaps you used the wrong -p or --strip option?
 > The text leading up to this was:
 > --------------------------
 > |diff --git a/tools/qemu-xen/include/hw/xen/xen_native.h b/tools/qemu-xen/include/hw/xen/xen_native.h
 > |index 6bcc83ba..2590904e 100644
 > |--- a/tools/qemu-xen/include/hw/xen/xen_native.h
 > |+++ b/tools/qemu-xen/include/hw/xen/xen_native.h
 > --------------------------
 > No file to patch.  Skipping patch.
 > 1 out of 1 hunk ignored
 > make: *** [package/pkg-generic.mk:239: output/build/xen-4.21.1/.stamp_patched] Error 1

 > To avoid making BR2_PACKAGE_XEN_TOOLS a required option, fix the
 > 0002-Update-linker-flags.patch so that modifying source from the qemu-xen
 > package is no longer included.

 > Instead of patching qemu-xen, a better solution is undefining the
 > __XEN_INTERFACE_VERSION__ from the qemu-xen package.

 > To test:
 > BR2_aarch64=y
 > BR2_TOOLCHAIN_EXTERNAL=y
 > BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
 > BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_GLIBC_STABLE=y
 > BR2_PACKAGE_XEN=y
 >  # BR2_PACKAGE_XEN_TOOLS is not set

 > Signed-off-by: Neal Frager <neal.frager@amd.com>

Committed, thanks - And sorry for the slow response!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot