From: Takashi Iwai <tiwai@suse.de>
To: Qingyu Zhang <usupergate@gmail.com>
Cc: perex@perex.cz, tiwai@suse.de, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: ump: do not touch legacy_rmidi before it exists
Date: Wed, 02 Sep 2026 11:11:13 +0200 [thread overview]
Message-ID: <877bl4auha.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260902073918.880245-1-usupergate@gmail.com>
On Wed, 02 Sep 2026 09:39:18 +0200,
Qingyu Zhang wrote:
>
> snd_ump_parse_endpoint() sets ump->parsed on every exit, including
> error, before the caller attaches the legacy rawmidi device.
> ump_handle_ep_name_msg() then treats parsed as "legacy_rmidi is live"
> and calls ump_legacy_set_rawmidi_name(), which snprintf()s into
> ump->legacy_rmidi->name. If a UMP packet arrives in that window
> (IRQ path from snd_ump_receive), legacy_rmidi is still NULL
> (KASAN null-ptr-deref in snprintf).
>
> Guard the legacy helpers. parsed only means endpoint info was
> parsed, not that legacy_rmidi exists.
>
> Fixes: 37e0e14128e0 ("ALSA: ump: Support UMP Endpoint and Function Block parsing")
> Signed-off-by: Qingyu Zhang <usupergate@gmail.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-09-02 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:39 [PATCH] ALSA: ump: do not touch legacy_rmidi before it exists Qingyu Zhang
2026-09-02 9:11 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bl4auha.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=usupergate@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.