Re: [PATCH V14 14/15] iothread: remove legacy iothread_get_aio_context()

[Markus Armbruster <armbru@redhat.com>]

Zhang Chen <zhangckid@gmail.com> writes:

> All production callers have migrated to either the holder-tracking
> iothread_ref_and_get_aio_context() API or the explicitly unsafe legacy
> accessor. Remove the now-unused ambiguous getter.
>
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> ---
>  include/system/iothread.h | 1 -
>  iothread.c                | 5 -----
>  2 files changed, 6 deletions(-)
>
> diff --git a/include/system/iothread.h b/include/system/iothread.h
> index 2ef8c1a1bb..9850cdb3dc 100644
> --- a/include/system/iothread.h
> +++ b/include/system/iothread.h
> @@ -66,7 +66,6 @@ DECLARE_INSTANCE_CHECKER(IOThread, IOTHREAD,
>  
>  char *iothread_get_id(IOThread *iothread);
>  IOThread *iothread_by_id(const char *id);
> -AioContext *iothread_get_aio_context(IOThread *iothread);
>  
>  /*
>   * Return @iothread's AioContext without registering a holder or taking a
> diff --git a/iothread.c b/iothread.c
> index 803d6ce3c3..3a092119ee 100644
> --- a/iothread.c
> +++ b/iothread.c
> @@ -422,11 +422,6 @@ char *iothread_get_id(IOThread *iothread)
>      return g_strdup(object_get_canonical_path_component(OBJECT(iothread)));
>  }
>  
> -AioContext *iothread_get_aio_context(IOThread *iothread)
> -{
> -    return iothread->ctx;
> -}
> -
>  AioContext *iothread_ref_and_get_aio_context(IOThread *iothread,
>                                               const IOThreadHolder *holder)
>  {

Easier, I think: squash PATCH 04 into this one.  Turns "add copy of old
function, change a caller to the copy, then delete old function eight
patches later" into "rename function to mark it unsafe".