Re: [PULL 12/25] gdbstub: Introduce GDBFeature structure

["Alex Bennée" <alex.bennee@linaro.org>]

Thomas Huth <thuth@redhat.com> writes:

> On 11/10/2023 12.33, Alex Bennée wrote:
>> From: Akihiko Odaki <akihiko.odaki@daynix.com>
>> Before this change, the information from a XML file was stored in an
>> array that is not descriptive. Introduce a dedicated structure type to
>> make it easier to understand and to extend with more fields.
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Message-Id: <20230912224107.29669-6-akihiko.odaki@daynix.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-Id: <20231009164104.369749-13-alex.bennee@linaro.org>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 9e7dec4a58..c3cc12dc29 100644
<snip>
>> +        if c == b'"'[0]:
>> +            sys.stdout.write('\\"')
>> +        elif c == b'\\'[0]:
>> +            sys.stdout.write('\\\\')
>> +        elif c == b'\n'[0]:
>> +            sys.stdout.write('\\n"')
>> +            quoted = False
>> +        elif c >= 32 and c < 127:
>> +            sys.stdout.write(c.to_bytes(1, 'big').decode())
>> +        else:
>> +            sys.stdout.write(f'\{c:03o}')
>
>  Hi!
>
> FWIW, this causes a warning on NetBSD:
>
> [913/4769] Generating gdbstub/gdbstub-xml.c with a custom command
> (wrapped by meson to capture output)
> /home/qemu/qemu-test.QowHuk/src/gdbstub/../scripts/feature_to_c.py:28:
> SyntaxWarning: invalid escape sequence '\{'
>   sys.stdout.write(f'\{c:03o}')
>
> I guess the backslash should simply be dropped? Or duplicated?

Paolo already fixed this in 7bca0ea74a049839e030c7fb33e82c0a7f7cd791
although I had a similar patch I obviously forgot to send....

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro