From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT
Date: Thu, 09 Jul 2026 18:34:49 +0200 [thread overview]
Message-ID: <877bn42kba.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260709121224.614350-1-rf@opensource.cirrus.com>
On Thu, 09 Jul 2026 14:12:24 +0200,
Richard Fitzgerald wrote:
>
> Make the Kconfig item for cirrus_scodec visible if CONFIG_KUNIT is
> enabled. This is so that its KUnit test can be enabled by KUnit
> scripts without requiring a large amount of irrelevant additional
> components.
>
> The general rule for KUNIT_ALL_TESTS is that it should only enable
> tests for components that are already selected. However, the UML
> environment does not support ACPI, which means the HDA codec drivers
> that use cirrus_scodec cannot be selected. But cirrus_scodec does not
> need ACPI.
>
> By making the Kconfig option visible if CONFIG_KUNIT, the KUnit test
> can be enabled with only the minimal set of functionality that is
> required for cirrus_scodec.
>
> This is still compliant with the KUNIT_ALL_TESTS rule "only tests
> for enabled modules" because by default cirrus_scodec will only be
> enabled if the drivers that use it are enabled. It must be
> intentionally enabled to force it to be included for testing.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2026-07-09 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 12:12 [PATCH] ALSA: hda/cirrus_scodec: Make Kconfig visible if KUNIT Richard Fitzgerald
2026-07-09 16:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bn42kba.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.