Re: [PATCH v3 00/12] reftable: harden against corrupted tables

[Toon Claes <toon@iotcl.com>]

Patrick Steinhardt <ps@pks.im> writes:

> Hi,
>
> this patch series addresses a bunch of errors that may happen when
> trying to read corrupted tables. These errors include out-of-bounds
> writes, out-of-bounds reads and the ability to hit abort(3p) calls.
>
> The out-of-bounds write was originally reported by awo on the security
> mailing list. As we never transfer reftables over the protocol it would
> require local disk access to create such corrupted reftables, so there
> isn't really an easy way to exploit these.
>
> In any case, I took that chance and wrote a fuzzer for parsing the
> tables, which surfaced a bunch of issues. At the end of this series
> though the fuzzer can now run for an extended amount of time (2hrs+)
> without surfacing any new issues.

Great work on providing the fixes with their corresponding unit tests.
I've manually verified if each test, and they all fail correctly without
the code changes.

All looks good to me. The only thing I'm not sure about is whether it's
useful to have the Asan output in the commit messages.

-- 
Cheers,
Toon