From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB5783F1AD9 for ; Tue, 7 Jul 2026 12:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.70.13.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783427028; cv=none; b=Sx07bcZcmIvqOdZcSFLQ/tq1P0oFJbWL7X5MogyX+TZPzBAKQoIb+6/lJs4MF94GjTPedRTvc5iIDXAe3++KODfVl8Bfij//b01C8iFV615a4HX+L4DtewfqETrvN413WAXaIYk9Y563ALQkI+9DGfAUyUGYm6nOEEu8LFy06x8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783427028; c=relaxed/simple; bh=AJvvWNVbJneve0RnBdB7HJP+ZJasGT4z94Jtlg7nSJc=; h=From:To:Cc:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Subject; b=qdujN3SzppNnx47cn2lG1G9IZNtK+EwnIg4PLO5p363Qf3wg8DPs5YRexerQ8EuNi51lYqX/AD6buxzqLc0Rh3BFzifWUrL0pYPexB7u6K7ix65yLej3yCGhfRFBVkIFP/FRzD0W9eZeDhMykL8BYnZICS2wdPpz1pkzINdsgqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com; spf=pass smtp.mailfrom=xmission.com; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b=Il76ZMdy; arc=none smtp.client-ip=166.70.13.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xmission.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b="Il76ZMdy" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=xmission.com; s=xmission; h=Subject:Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AJvvWNVbJneve0RnBdB7HJP+ZJasGT4z94Jtlg7nSJc=; b=Il76ZMdysHX1AvSxYheX5FE4Yb BPSLGA5exRPNoEe8BofIljIfcW1Fk5tZnJ8Lb1WstKPXJfi5vloKlsMVAeeKtFG8afyPUBqzUz9gi zN5DRQ1NyNr0JFcdBHW5Qajjk4yAXVWCQe8X79O7Y5GuI0zV6+pnZgo8zAnhKy2YswdM=; Received: from in02.mta.xmission.com ([166.70.13.52]:50520) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wh4pu-005cSC-Px; Tue, 07 Jul 2026 06:23:38 -0600 Received: from ip72-198-198-28.om.om.cox.net ([72.198.198.28]:50138 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wh4pu-006uAG-0H; Tue, 07 Jul 2026 06:23:38 -0600 From: "Eric W. Biederman" To: Oleg Nesterov Cc: Andrew Morton , Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Linus Torvalds , Christian Brauner In-Reply-To: (Oleg Nesterov's message of "Tue, 7 Jul 2026 13:21:30 +0200") References: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> <877bnh7tnf.fsf@email.froward.int.ebiederm.org> <877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org> <871pdj4uxa.fsf_-_@email.froward.int.ebiederm.org> Date: Tue, 07 Jul 2026 07:23:32 -0500 Message-ID: <877bn7xa2j.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1wh4pu-006uAG-0H;;;mid=<877bn7xa2j.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=72.198.198.28;;;frm=ebiederm@xmission.com;;;sPfnum=0;;;sPf=pass X-XM-AID: U2FsdGVkX184JBLlqAfRe6OalLbUDjSHIi8y4nCfin4= X-Spam-Level: * X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4999] * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Oleg Nesterov X-Spam-Relay-Country: X-Spam-Timing: total 374 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 11 (2.8%), b_tie_ro: 9 (2.5%), parse: 0.91 (0.2%), extract_message_metadata: 3.0 (0.8%), get_uri_detail_list: 0.79 (0.2%), tests_pri_-2000: 3.2 (0.9%), tests_pri_-1000: 2.8 (0.8%), tests_pri_-950: 1.22 (0.3%), tests_pri_-900: 1.12 (0.3%), tests_pri_-90: 134 (35.9%), check_bayes: 133 (35.5%), b_tokenize: 5 (1.5%), b_tok_get_all: 4.3 (1.2%), b_comp_prob: 1.55 (0.4%), b_tok_touch_all: 118 (31.6%), b_finish: 0.90 (0.2%), tests_pri_0: 193 (51.5%), check_dkim_signature: 0.58 (0.2%), check_dkim_adsp: 2.5 (0.7%), poll_dns_idle: 0.68 (0.2%), tests_pri_10: 2.4 (0.6%), tests_pri_500: 14 (3.6%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 01/14] signal: Generalize posixtimer_queue_sigqueue into enqueue_signal X-SA-Exim-Connect-IP: 166.70.13.52 X-SA-Exim-Rcpt-To: brauner@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, wad@chromium.org, tglx@kernel.org, peterz@infradead.org, kusaram@devineni.in, kees@kernel.org, luto@kernel.org, akpm@linux-foundation.org, oleg@redhat.com X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out03.mta.xmission.com); SAEximRunCond expanded to false Oleg Nesterov writes: > On 07/03, Eric W. Biederman wrote: >> >> +static void enqueue_signal(struct task_struct *t, enum pid_type type, >> + int sig, struct sigqueue *q) >> +{ >> + struct signal_struct *signal = t->signal; >> + struct sigpending *pending = (type != PIDTYPE_PID) ? >> + &signal->shared_pending : &t->pending; >> + >> + signalfd_notify(t, sig); >> + if (q) { >> + list_add_tail(&q->list, &pending->list); >> + } >> + sigaddset(&pending->signal, sig); >> + complete_signal(sig, t, type); >> +} > > Hmm... __send_signal_locked() doesn't initialize the local "struct sigqueue *q", and > > if ((sig == SIGKILL) || (t->flags & PF_KTHREAD)) > goto out_set; > > will pass it to enqueue_signal(). Doh! Thank you for catching that. That is an embarrassing oversight. Fixed in my tree now. Eric