From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Jens Axboe <axboe@kernel.dk>, Yang Xiuwei <yangxiuwei@kylinos.cn>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring/net: fix netmsg_cache iovec leak on BIND and CONNECT
Date: Wed, 17 Jun 2026 11:41:55 -0400 [thread overview]
Message-ID: <877bnxfa2k.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <870ac7c0-a521-45b0-ab0b-fed5f97a319f@kernel.dk>
Jens Axboe <axboe@kernel.dk> writes:
> On 6/16/26 9:30 PM, Yang Xiuwei wrote:
>> Hi Jens,
>>
>> Please drop this patch.
>
> Haven't picked it up, nothing to drop.
>
>> After rebasing on the latest io_uring tree, I noticed that this issue
>> has already been fixed upstream by:
>>
>> 3979840cd858 ("io_uring/net: Avoid msghdr on op_connect/op_bind async data")
>>
>> BIND and CONNECT no longer allocate async data from netmsg_cache via
>> io_msg_alloc_async(). They now use struct sockaddr_storage directly, so
>> the iovec leak path described in my patch no longer exists. My fix is
>> also incorrect on the current code base.
>
> But then we should probably mark 3979840cd858 for stable, then? Gabriel,
> can you take a look? Currently traveling...
ack. will do.
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2026-06-17 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 2:53 [PATCH] io_uring/net: fix netmsg_cache iovec leak on BIND and CONNECT Yang Xiuwei
2026-06-17 3:30 ` Yang Xiuwei
2026-06-17 15:07 ` Jens Axboe
2026-06-17 15:41 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bnxfa2k.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=yangxiuwei@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.