From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC134CD5BC9 for ; Mon, 25 May 2026 18:43:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wRaH5-0004vE-MD; Mon, 25 May 2026 14:43:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wRaH3-0004ue-QG for qemu-arm@nongnu.org; Mon, 25 May 2026 14:43:37 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wRaH2-0000yf-6D for qemu-arm@nongnu.org; Mon, 25 May 2026 14:43:37 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so72699985e9.0 for ; Mon, 25 May 2026 11:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779734614; x=1780339414; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nzfKWv9JzU5mMugxKaK6qPwERMr9J1AgOUmy+aHJ24g=; b=s81ciKku0rudltbtvwdI2l7ki0VOGpMrEGbc1O8sFqJ7uvj3Q1jWy1UJqWdR4shyBd Az55GEI/5u57u42UE5UFG5ojEEVoA8HfQ2xaRNzTMeDkFD6bgpP14Xkq56ea4T1AJf22 lYyvM6e8LVkXtugzDZPW9LtKeXP35GBtMfymt11SxT+QPO9FbDqltlgnIcr8qlC2Z9ql gQsUHc3r8td1bFqx/ck2rg+BewG6CMJsZeWanAfB2Y+pjGWVKLDX+bNhSITd4PWoRc4U /oLT5CY2+yaxGc7eQVdUrRyn8BaIzvJO4cynHG3Hb7P5YFUg1fJtrlquUnT8SoNSp6YM dogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779734614; x=1780339414; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nzfKWv9JzU5mMugxKaK6qPwERMr9J1AgOUmy+aHJ24g=; b=j70NVah01BNfZZFgZXTONA4Y8risxqlpdLETKnSXxG66kLJo3cESXzADQ9g2MeF0Au EhgNlmLUN77hxPuz2/KpK6R1xkfw+xs0Sq5/IWosDMhou8N1g1K3i1UONkI1s1kt5BzW 9QrtAvM0yV1HgIn/N4QzksfvzeosJw1rZTSbLGkLYAmMVKhmXfxRFaihD4IHehVf/db/ aR6+RlZdC364JzpuL+hoBUSjQOqd3KWBOUqtlRIpdB/rYaTRQ6xZnN41OwDdXA4ZmWLI ZPTeqhSOBsHEGoGAyDJL4MvVB9s1NVE9bMj5eRUVK6kVKza9up+KoMotwJlOaRSlP1om mZkw== X-Forwarded-Encrypted: i=1; AFNElJ8gZ6AZWLwWbfgUGYjx9Tc+YxGyutKXbwZd6fodthGPBC0YuWeCI8dY+mZahqyON8RgYApYj4aXWQ==@nongnu.org X-Gm-Message-State: AOJu0YzDiH86WXGmzOPjCZMdvN4HEfluG9AuCjtNTsPrSYLPd5/HMx8R dzzOY08/Oglrm3fL85hIPXiml6UYdYC5NHWe3/JqVGfVxkSKr0JS5ykTzJc+ntqPVjQ= X-Gm-Gg: Acq92OG4NaELwpuEQa33lcOQeqFyFHnbvQHKenGdjkTJG/y8tqA2/W0ZIfJamuoen1q X6Q38VatF66EWP6Tf2GQiwk4CUAgNABYH1zPy5n8IpwZeT++e3a07P2ngVrIDxjBKk6S/CU7s7z aPr89m1aGzOM7uZ7RWjX22hqVIScFqSYUnabnPrqDD9nMx/elWXy/76OZoGsJuX1Xf3QuQ6fbfy DelIXu30zpMvd7MX/Eidg4R5rPqKYaQgT651VCVdlE8LdN+4jKcdyjltKVCboEgC2QB7HPKHJ9j eHVgbHXh4znqAfMWBtNu2jV/6//Ic+5Pf7Km7HOmUe81Ty/D7m+39l6rWHNZhg7zOg8uA7uSNGg h+/FbmJYZcLMobDVDkRrqnsRYjjOnERA9OwxsYwSXK7WYH+kX+yR4Jz0brUkHHHyZ23JBAU1NFA SwSziJr8zRc6Itu4Vv4Nj9HyoRL4HXUg+hOA== X-Received: by 2002:a05:600c:8217:b0:490:51e9:deba with SMTP id 5b1f17b1804b1-49051e9e233mr175536925e9.27.1779734614129; Mon, 25 May 2026 11:43:34 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6cd1780sm31122078f8f.16.2026.05.25.11.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 11:43:33 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 40D575F855; Mon, 25 May 2026 19:43:32 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Peter Xu , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Thomas Huth , Song Gao , John Snow , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Kyle Evans , Pierrick Bouvier , Cleber Rosa , Warner Losh , Brad Smith , Thomas Huth , Paolo Bonzini , Max Filippov , Brian Cain , Fabiano Rosas , Peter Maydell , Richard Henderson , qemu-arm@nongnu.org Subject: Re: [PATCH v2 03/16] tests/Makefile.include: add binary dependency to run-tcg-tests-% rules In-Reply-To: <0f73d717-1621-4c3f-9c5e-9bfdfaffb0b8@oss.qualcomm.com> (Pierrick Bouvier's message of "Mon, 25 May 2026 10:18:45 -0700") References: <20260521131739.540157-1-alex.bennee@linaro.org> <20260521131739.540157-4-alex.bennee@linaro.org> <74e8bc86-cd81-43f9-b5cb-7e3de3bcd3d0@oss.qualcomm.com> <87tsrzl138.fsf@draig.linaro.org> <093614fb-ced1-4b15-b1e1-5da755f87237@oss.qualcomm.com> <87cxymec7b.fsf@draig.linaro.org> <5bd51a1a-4079-4073-bbd8-f0206a1ad458@oss.qualcomm.com> <0f73d717-1621-4c3f-9c5e-9bfdfaffb0b8@oss.qualcomm.com> User-Agent: mu4e 1.14.1; emacs 30.1 Date: Mon, 25 May 2026 19:43:32 +0100 Message-ID: <877bor9vor.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Pierrick Bouvier writes: > On 5/25/2026 8:46 AM, Pierrick Bouvier wrote: >> On 5/23/2026 1:56 AM, Alex Benn=C3=A9e wrote: >>> Pierrick Bouvier writes: >>> >>>> On 5/22/2026 12:02 PM, Alex Benn=C3=A9e wrote: >>>>> Pierrick Bouvier writes: >>>>> >>>>>> On 5/21/2026 6:17 AM, Alex Benn=C3=A9e wrote: >>>>>>> Explicitly set the appropriate QEMU binary as a dependency so we can >>>>>>> ensure they get built. This is especially important for MacOS which >>>>>>> otherwise only builds the unsigned binaries on a normal "make all" >>>>>>> run. >>>>>>> >>>>>> >>>>>> I'm not sure to see why it matters. tcg-tests don't make use of hvf,= so >>>>>> unsigned binaries are plenty for it. >>>>>> >>>>>> Which other binary is this building that is not built by default? >>>>>> >>>>>> In general, if something is not included in "all" target, let's make >>>>>> sure it's included there (meson.build?) instead of adding a workarou= nd >>>>>> here. Not only tests benefit this, but anyone doing a build on a >>>>>> platform that might have optional binaries not built by default. >>>>> >>>>> If you have a suggestion on how to make that work I'm all ears. >>>>> >>>> >>>> I would be happy to help, but I don't understand what the goal is. I >>>> have three questions that should help to provide a suggestion. >>>> >>>> Which exact test command do you run? >>> >>> make check-tcg >>> >>>> >>>> ``` >>>> Explicitly set the appropriate QEMU binary as a dependency so we can >>>> ensure they get built. >>>> ``` >>>> Aren't they built by all? >>> >>> Apparently not. >>> >>>> It seems to be a dependency, at least for check-tcg: >>>> .ninja-goals.check-tcg =3D all test-plugins >>>> >>>> ``` >>>> This is especially important for MacOS which otherwise only builds the >>>> unsigned binaries on a normal "make all" run. >>>> ``` >>>> Why do you need signed binaries for testing on MacOS (hvf?)? >>> >>> In a previous iteration I made configure spit out the unsigned binaries >>> to config-target.mak but the request was to fix the dependencies >>> instead. >>> >>> It all works on Linux so I'm not sure why MacOS is being so weird >>> because the meson emulators target mechanism should be the same. >>> >>=20 >> Just tried now, and it does not work on Linux neither (make check-tcg >> does not build any target beyond tests). Maybe you forgot to clean your >> folder? >> > > The root issue is that tests/Makefile.include is included *after* > evaluation of ninja-targets in main Makefile. Thus, > .ninja-goals.check-tcg is ignored. So this replaces patch 1/16 - I think we have a circular dependency here. > > The fix is to move ninja-targets evaluation to the end of main Makefile, > which introduce the expected dependency for check-tcg to "all > test-plugins" targets. > > You can replace current patch with the one attached to this email. > > Regards, > Pierrick --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro