All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>,
	Marek Vasut <marek.vasut@mailbox.org>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Marek Vasut <marek.vasut+usb@mailbox.org>,
	Gurumoorthy Santhakumar
	<gurumoorthy.santhakumar@oss.qualcomm.com>,
	u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>,
	Casey Connolly <casey.connolly@linaro.org>,
	Chris Morgan <macromorgan@hotmail.com>,
	Varadarajan Narayanan <quic_varada@quicinc.com>
Subject: Re: [PATCH v3] usb: dwc3: Fix crash on fastboot exit due to incorrect memory free
Date: Mon, 11 May 2026 10:51:54 +0200	[thread overview]
Message-ID: <877bpawcph.fsf@kernel.org> (raw)
In-Reply-To: <403bb698-be10-4b4f-9a30-df70847b61fb@oss.qualcomm.com>

On Fri, May 08, 2026 at 09:17, Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com> wrote:

> On 5/7/2026 10:55 PM, Marek Vasut wrote:
>> On 5/7/26 5:20 PM, Balaji Selvanathan wrote:
>>> The dwc3_free_one_event_buffer() function incorrectly called free()
>>> on event buffer structures allocated with devm_kzalloc(). This
>>> caused heap corruption and a synchronous abort when exiting
>>> fastboot mode via "fastboot continue".
>>>
>>> Device-managed memory is automatically freed when the device is
>>> removed, so manual deallocation causes the heap allocator to access
>>> corrupted metadata.
>>>
>>> Fixes: 884b10e86a05 ("usb: dwc3: core: fix memory leaks in event 
>>> buffer cleanup")
>>> Signed-off-by: Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>
>> Reviewed-by: Marek Vasut <marek.vasut+usb@mailbox.org>
>>
>> Did Mattijs RB got dropped ?
>
> Hi,
>
> Thought Mattijs will give reviewed-by after placing "Fixes:" tag in 
> commit footer.

Usually, when comments are only nitpicks, it's okay to keep the
Reviewed-by tag.

Putting it back here:

Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>

>
> Thanks

  reply	other threads:[~2026-05-11  8:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07 15:20 [PATCH v3] usb: dwc3: Fix crash on fastboot exit due to incorrect memory free Balaji Selvanathan
2026-05-07 17:25 ` Marek Vasut
2026-05-08  3:47   ` Balaji Selvanathan
2026-05-11  8:51     ` Mattijs Korpershoek [this message]
2026-05-11 17:25 ` Alexey Charkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bpawcph.fsf@kernel.org \
    --to=mkorpershoek@kernel.org \
    --cc=balaji.selvanathan@oss.qualcomm.com \
    --cc=casey.connolly@linaro.org \
    --cc=gurumoorthy.santhakumar@oss.qualcomm.com \
    --cc=macromorgan@hotmail.com \
    --cc=marek.vasut+usb@mailbox.org \
    --cc=marek.vasut@mailbox.org \
    --cc=quic_varada@quicinc.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.