From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 368DB37649A for ; Thu, 19 Mar 2026 09:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913721; cv=none; b=RbgFNkU80PTeFsRRqZN4b+QTJqfrdU6z7pltlg7KoEWO0uvTpIiEJxRvNnOerDZLzioxnq2fueKUlsDfZFH/j4fgMmvZ3OtafoQFu59GbyqwoxJctMNsfdEGfq0r4x1iDH7yxREhV7aYRvIgNrgdRaFsmLqz07faw2lw5bZhP2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773913721; c=relaxed/simple; bh=1CDzx2c23sJ7YfWsGb1lT7TwRWchpdo5KPBkEtG6oxQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=G5xqHvnek6poceZgwxtW6NqvA13f+/tTrbDlW77ZovkwDyAQ5IwnSA6uK47/LNcEYVWomev0aioddFAdG0NyX4t9O4pBs35XiZK559Bfq3nQk16ex8d6F+VqK8y43R1H514y11AFs7Ad6JzDC1aQLw5yaafXyDWzcqe9lE2EAIw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=eXApkYG/; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=V5iWNcb8; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="eXApkYG/"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="V5iWNcb8" From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1773913717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wa2Dkzy3iomEaCU/pNUfFF+jBd1aQT4UpunyGUS/3us=; b=eXApkYG/j+NAD20oSF3yDi5LcSSuIGdhJOGt7MzJr22KFqcrd8z3ZsFxI5J9VGubG8+XzP pNZ+Jj7/fqpaNxhhWDu+xrNCtGmXAkWgaigZh3P66pyhr4NVpY0z4HOObdFXNmZDu5Ocgr PZZhCxZU5DNbpKU5SKDl4TlMvSlg2+WBee4p5pp7xN0XGyEFaFrZeJYEXN3JEsrB5q9iit mZas1BEVMQacyQTeyTA1VwiRAwOEbWYdtMAlPyRuWgFhiLnIWVZ2hvq1tv5Ou17yFdN+mn 9eSXz1C7I6v3lXF4mvXQULmRBvAdR2dqSyno2eQFTDfHc/S/bKvTl2g/spg8Gg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1773913717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wa2Dkzy3iomEaCU/pNUfFF+jBd1aQT4UpunyGUS/3us=; b=V5iWNcb8WQV6l6GPzJM23EDMBVeowfsa2edIs8FwheRkaxKSVmVwzmw8aB4rQx+jaI45di Nd8pRFzkdGiWlMDw== To: Thorsten Blum , Petr Mladek , Steven Rostedt , Sergey Senozhatsky Cc: Thorsten Blum , Herbert Xu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] printk: add print_hex_dump_devel() In-Reply-To: <87a4w4gnj2.fsf@jogness.linutronix.de> References: <20260319092932.208939-3-thorsten.blum@linux.dev> <87a4w4gnj2.fsf@jogness.linutronix.de> Date: Thu, 19 Mar 2026 10:54:37 +0106 Message-ID: <877br8gney.fsf@jogness.linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 2026-03-19, John Ogness wrote: >> +#define print_hex_dump_devel(prefix_str, prefix_type, rowsize, \ >> + groupsize, buf, len, ascii) \ >> + print_hex_dump(KERN_DEBUG, prefix_str, prefix_type, rowsize, \ >> + groupsize, buf, len, ascii) >> +#else >> +static inline void print_hex_dump_devel(const char *prefix_str, int prefix_type, >> + int rowsize, int groupsize, >> + const void *buf, size_t len, bool ascii) >> +{ >> +} > > If you look at the implementation of pr_devel(), it is using no_printk() > in the !DEBUG case. I believe this is to validate correct arg > formatting, even if the code will optimized out. Sorry, print_hex_dump() has no printf formatting. Reviewed-by: John Ogness