All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: Oliver Upton <oupton@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Alexander Potapenko <glider@google.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	Timothy Hayes <timothy.hayes@arm.com>,
	Sascha Bischoff <Sascha.Bischoff@arm.com>,
	Keir Fraser <keirf@google.com>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: vgic: Handle const qualifier from gic_kvm_info allocation type
Date: Wed, 25 Feb 2026 21:10:00 +0000	[thread overview]
Message-ID: <877bs0edhz.wl-maz@kernel.org> (raw)
In-Reply-To: <202602251238.9850FCB@keescook>

On Wed, 25 Feb 2026 20:40:59 +0000,
Kees Cook <kees@kernel.org> wrote:
> 
> On Fri, Feb 13, 2026 at 03:03:24PM +0000, Marc Zyngier wrote:
> > On Fri, 06 Feb 2026 14:30:23 -0800, Kees Cook wrote:
> > > In preparation for making the kmalloc family of allocators type aware,
> > > we need to make sure that the returned type from the allocation matches
> > > the type of the variable being assigned. (Before, the allocator would
> > > always return "void *", which can be implicitly cast to any pointer type.)
> > > 
> > > The assigned type is "struct gic_kvm_info", but the returned type,
> > > while matching, is const qualified. To get them exactly matching, just
> > > use the dereferenced pointer for the sizeof().
> > > 
> > > [...]
> > 
> > Applied to fixes, thanks!
> > 
> > [1/1] KVM: arm64: vgic: Handle const qualifier from gic_kvm_info allocation type
> >       commit: ee5c38a8d31e5dea52299c43c2ec3213351ab6e1
> 
> Just a heads-up that I ended up sending this patch to Linus for -rc1 as
> it was a prerequisite for the tree-wide kmalloc_obj refactoring. Sorry
> for any merge conflicts this might create for your tree! It is now
> commit c732084c891d there.

Yup, I noticed it this morning as I was preparing the first batch of
fixes for KVM/arm64.

I'd appreciate it if in the future you would let me know upfront what
route you expect a given patch to take -- I'll happily give an ack for
a patch you want to route directly to Linus, rather than carrying it
and ending up with conflicts with upstream.

Thanks,

	M.

-- 
Jazz isn't dead. It just smells funny.

      reply	other threads:[~2026-02-25 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 22:30 [PATCH v2] KVM: arm64: vgic: Handle const qualifier from gic_kvm_info allocation type Kees Cook
2026-02-13 15:03 ` Marc Zyngier
2026-02-25 20:40   ` Kees Cook
2026-02-25 21:10     ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877bs0edhz.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=Sascha.Bischoff@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=glider@google.com \
    --cc=joey.gouly@arm.com \
    --cc=kees@kernel.org \
    --cc=keirf@google.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oupton@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=timothy.hayes@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.