From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id D99B51DB13A
	for <linux-kernel@vger.kernel.org>; Wed, 10 Dec 2025 06:50:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1765349440; cv=none; b=Zp09oJTvtuO96ez8PifzaZu6334JTOeqxzU9zgtBAODWSl7n7Z1AUppJ7Po95Fq4noXnvn267pajmcfW+co0Bx7mWcf2hE5d2x2ddkvexC5/a6nsXgF/z2xruHtRfobreyRXkuaYsCfd92VXJTnKRf1ujh/fOnt35Yj4/4MHd8c=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1765349440; c=relaxed/simple;
	bh=LMrAsG67YOnKYsL9loa9lnIeu9wtoTc35AyRmFm1uPA=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=OU+XqzpX0HMtNt2xewfYi38lCNjacyjU7KsoWJFKqALswfNRwMyUaAY4aLh58eynW64xKeoYEfWuQ7f8RPa5C/58V1OwUooETl0N1T7hD9dBuI2dzH+21Q8cRJuqxRWLAkYQZ8E1lLNzyEZ00A6884k8MMNfaM979FSRBx4rSAo=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=YrAYoKgD; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=fQndDSGB; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YrAYoKgD";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="fQndDSGB"
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1765349436;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QEtJE+XYkwYIuf+6M/1z95lDLJ4FLv3FCp0jdOqaVqQ=;
	b=YrAYoKgDBPjUdCqyCstddO5bWSf63sgvzJJkO7qWmyQG4i5mr+IQocq3m2qX7ezLIXvxRX
	W+mg/lpV2lCPhetsGXK4yklpsCY3w9Ed2L8VBTc5QyqzEAscRPtfoZEIXQbEXS8trzXde2
	px1CznakqdLO5r90WouHK/z7SpMGLNenMgwLV6DlkLETFCKkv9rFV60DeRFBPHLliY99Pn
	FpOrlAQKoYn9AG9lJ8ZI+wY62fLMl3K4GWmOEbnA8+W/IhysCA8C+sde9iC3wAnX2u3Ogi
	sweSNmPG2czgAUm37TaDC/81WHNs+Ickhj+S4hjog72PltviRBk/c680w3dR8g==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1765349436;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=QEtJE+XYkwYIuf+6M/1z95lDLJ4FLv3FCp0jdOqaVqQ=;
	b=fQndDSGBFw/8IMgc3GhWCeIWizf5MvdBnmxTnOUWRCGJVKFzGjYycUdLICyGMW+5b8/smr
	GZN86sPReQAy0mAA==
To: Kaushlendra Kumar <kaushlendra.kumar@intel.com>, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smpboot: Add NULL check before kthread_unpark()
In-Reply-To: <20251124051144.1427596-1-kaushlendra.kumar@intel.com>
References: <20251124051144.1427596-1-kaushlendra.kumar@intel.com>
Date: Wed, 10 Dec 2025 15:50:29 +0900
Message-ID: <877buug79m.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Mon, Nov 24 2025 at 10:41, Kaushlendra Kumar wrote:
> Add NULL check for tsk before calling kthread_unpark() in
> smpboot_unpark_thread() to prevent potential null pointer
> dereference.

How is that ever going to be NULL?

Thanks,

        tglx