Re: [PATCH 1/3] man/man2/gettimeofday.2: Declare gettimeofday with [[deprecated]].

[Collin Funk <collin.funk1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

Hi Alex,

Alejandro Colomar <alx@kernel.org> writes:

>> -.BI "int gettimeofday(struct timeval *restrict " tv ,
>> -.BI "                 struct timezone *_Nullable restrict " tz );
>> +.BI "[[deprecated]] int gettimeofday(struct timeval *restrict " tv ,
>
> Please put the attribute in a separate line, to avoid bad alignment.

I thought my patch had lines that were too long, but I wasn't sure of a
better way to format it. If I understand correctly, you suggest:

    .BI "[[deprecated]]"
    .BI "int gettimeofday(struct timeval *restrict " tv ,
    .BI "                 struct timezone *_Nullable restrict " tz );

But I think the [[deprecated]] looks a bit strange alone on that line.
Maybe the return type 'int' should be placed on the line with it. What
do you think?

>>  .BI "int settimeofday(const struct timeval *" tv ,
>>  .BI "                 const struct timezone *_Nullable " tz );
>
> Should settimeofday(2) be considered deprecated too, even if it was
> never standard?  It doesn't seem to make much sense to keep it intact if
> the get*() one is deprecated.

Sure, it seems pretty uncontroversial to deprecate it ourselves. In V2 I
can also add the [[deprecated]] there and recommend 'clock_settime'
instead in HISTORY.

I will wait for your input on the declaration formatting first though.

Collin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]