From: Jani Nikula <jani.nikula@linux.intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v3 3/4] drm/print: Add drm_printer_is_full
Date: Wed, 16 Apr 2025 10:14:43 +0300 [thread overview]
Message-ID: <877c3kr318.fsf@intel.com> (raw)
In-Reply-To: <Z/6TB/QNRrCAtbIc@lstrano-desk.jf.intel.com>
On Tue, 15 Apr 2025, Matthew Brost <matthew.brost@intel.com> wrote:
> On Thu, Apr 10, 2025 at 03:06:32PM +0300, Jani Nikula wrote:
>> On Wed, 09 Apr 2025, Matthew Brost <matthew.brost@intel.com> wrote:
>> > Add drm_printer_is_full which indicates if a drm printer's output is
>> > full. Useful to short circuit coredump printing once printer's output is
>> > full.
>>
>> The function is presented as a generic drm_printer thing, but it's
>> really only valid for a coredump printer, and will return random results
>> for other printers. Which can't even be "full" in any meaningful sense,
>> making the documentation for the function seem completely weird.
>>
>
> So maybe:
>
> s/drm_printer_is_full/drm_coredump_printer_is_full?
Works for me.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-04-16 7:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 4:06 [PATCH v3 0/4] Large devcoredump file support Matthew Brost
2025-04-10 4:06 ` [PATCH v3 1/4] drm/xe: Add devcoredump chunking Matthew Brost
2025-04-10 17:47 ` John Harrison
2025-04-10 4:06 ` [PATCH v3 2/4] drm/xe: Update xe_ttm_access_memory to use GPU for non-visible access Matthew Brost
2025-04-10 4:06 ` [PATCH v3 3/4] drm/print: Add drm_printer_is_full Matthew Brost
2025-04-10 12:06 ` Jani Nikula
2025-04-15 17:10 ` Matthew Brost
2025-04-16 7:14 ` Jani Nikula [this message]
2025-04-10 4:06 ` [PATCH v3 4/4] drm/xe: Abort printing coredump in VM printer output if full Matthew Brost
2025-04-10 4:11 ` ✓ CI.Patch_applied: success for Large devcoredump file support Patchwork
2025-04-10 4:11 ` ✓ CI.checkpatch: " Patchwork
2025-04-10 4:12 ` ✓ CI.KUnit: " Patchwork
2025-04-10 4:28 ` ✗ CI.Build: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c3kr318.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.