From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Maciej Strozek <mstrozek@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM
Date: Wed, 12 Mar 2025 16:11:03 +0100 [thread overview]
Message-ID: <877c4uz3lk.wl-tiwai@suse.de> (raw)
In-Reply-To: <87a59qz3qw.wl-tiwai@suse.de>
On Wed, 12 Mar 2025 16:07:51 +0100,
Takashi Iwai wrote:
>
> On Wed, 12 Mar 2025 15:56:39 +0100,
> Takashi Iwai wrote:
> >
> > Put __maybe_unused to work around the build error without CONFIG_PM
> > or CONFIG_PM_SLEEP for the newly defined system suspend callback.
>
> I think a better alternative would be to wrap with pm_sleep_ptr().
> Will resubmit.
... and no, it won't work together with SET_SYSTEM_SLEEP_PM_OPS() :-<
So this patch should be the easiest fix, I suppose.
Takashi
next prev parent reply other threads:[~2025-03-12 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 14:56 [PATCH] ASoC: cs42l43: Fix build error without CONFIG_PM Takashi Iwai
2025-03-12 15:07 ` Takashi Iwai
2025-03-12 15:11 ` Takashi Iwai [this message]
2025-03-12 15:34 ` Mark Brown
2025-03-12 15:37 ` Takashi Iwai
2025-03-12 15:48 ` Charles Keepax
2025-03-12 15:55 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c4uz3lk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-sound@vger.kernel.org \
--cc=mstrozek@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.