Re: [PATCH 0/2] drm: revert some framebuffer API tests

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 25 Sep 2024, Maxime Ripard <mripard@kernel.org> wrote:
> On Wed, Sep 25, 2024 at 01:52:02PM GMT, Simona Vetter wrote:
>> I think for at least drm the consensus is clear, we won't have kunit tests
>> that splat.
>
> Where was that ever discussed?

Well, where was it ever agreed that it's okay for drm kunit tests to
emit warnings? :p

>> Personally I really don't see the point of unit tests that are
>> somewhere between unecessarily hard or outright too much pain to
>> deploy in a test rig: Either you don't run them (not great), or you
>> filter splats and might filter too much (not great either) or you
>> filter as little as possible and fight false positives (also kinda
>> suboptimal).
>
> Or you don't do any of that, and just rely on the canonical way to run
> kunit test and trust it's going to pass tests that do indeed pass, and
> fail / warn on those that don't.

That still doesn't address code being tested emitting *unexpected*
warnings.


BR,
Jani.


-- 
Jani Nikula, Intel