All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Chen Yufan <chenyufan@vivo.com>, John Stultz <jstultz@google.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org
Cc: opensource.kernel@vivo.com, Chen Yufan <chenyufan@vivo.com>
Subject: Re: [PATCH v3] timekeeping: Use time_after() in timekeeping_check_update()
Date: Sun, 01 Sep 2024 21:01:14 +0200	[thread overview]
Message-ID: <877cbv8ah1.ffs@tglx> (raw)
In-Reply-To: <20240830015459.2937-1-chenyufan@vivo.com>

On Fri, Aug 30 2024 at 09:54, Chen Yufan wrote:
> Use time_after because the open coded comparison 
> does not handle wrap arounds correctly.
>
> Signed-off-by: Chen Yufan <chenyufan@vivo.com>
> ---
> The modifications made compared to the previous version are as follows:
> 1. change the type of timekeeper::last_warning to
> unsigned long because time_after() requires its
> parameters to be unsigned long.

The change of the struct member wants to be explained in the change log
and not in the version history. I told you so, no?

Thanks,

        tglx



      reply	other threads:[~2024-09-01 19:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  1:54 [PATCH v3] timekeeping: Use time_after() in timekeeping_check_update() Chen Yufan
2024-09-01 19:01 ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cbv8ah1.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=chenyufan@vivo.com \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opensource.kernel@vivo.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.