From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>, <sdf@fomichev.me>,
<shuah@kernel.org>, <petrm@nvidia.com>
Subject: Re: [PATCH net-next v3] selftests: net: ksft: print more of the stack for checks
Date: Mon, 5 Aug 2024 11:37:41 +0200 [thread overview]
Message-ID: <877ccv5myt.fsf@nvidia.com> (raw)
In-Reply-To: <20240801232317.545577-1-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> Print more stack frames and the failing line when check fails.
> This helps when tests use helpers to do the checks.
>
> Before:
>
> # At ./ksft/drivers/net/hw/rss_ctx.py line 92:
> # Check failed 1037698 >= 396893.0 traffic on other queues:[344612, 462380, 233020, 449174, 342298]
> not ok 8 rss_ctx.test_rss_context_queue_reconfigure
>
> After:
>
> # Check| At ./ksft/drivers/net/hw/rss_ctx.py, line 387, in test_rss_context_queue_reconfigure:
> # Check| test_rss_queue_reconfigure(cfg, main_ctx=False)
> # Check| At ./ksft/drivers/net/hw/rss_ctx.py, line 230, in test_rss_queue_reconfigure:
> # Check| _send_traffic_check(cfg, port, ctx_ref, { 'target': (0, 3),
> # Check| At ./ksft/drivers/net/hw/rss_ctx.py, line 92, in _send_traffic_check:
> # Check| ksft_lt(sum(cnts[i] for i in params['noise']), directed / 2,
> # Check failed 1045235 >= 405823.5 traffic on other queues (context 1)':[460068, 351995, 565970, 351579, 127270]
> not ok 8 rss_ctx.test_rss_context_queue_reconfigure
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
prev parent reply other threads:[~2024-08-05 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 23:23 [PATCH net-next v3] selftests: net: ksft: print more of the stack for checks Jakub Kicinski
2024-08-02 23:30 ` patchwork-bot+netdevbpf
2024-08-05 9:37 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ccv5myt.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.