From: Kalle Valo <kvalo@kernel.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: syzbot+51a42f7c2e399392ea82@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
srini.raju@purelifi.com, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] wifi: plfxlc: remove assert for mac->lock
Date: Tue, 30 Jul 2024 13:35:07 +0300 [thread overview]
Message-ID: <877cd39nhg.fsf@kernel.org> (raw)
In-Reply-To: <tencent_03969636CA4BC874A7763F66D23D15366009@qq.com> (Edward Adam Davis's message of "Tue, 30 Jul 2024 12:28:42 +0800")
Edward Adam Davis <eadavis@qq.com> writes:
> syzbot report WARNING in plfxlc_mac_release, according to the context,
> there is not need assert for mac->lock.
The commit message should explain _why_ the assert is not needed.
Otherwise it looks that you are randomly removing it to get rid of the
warning.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-07-30 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 18:50 [syzbot] [wireless?] WARNING in plfxlc_mac_release syzbot
2024-07-30 3:06 ` Edward Adam Davis
2024-07-30 3:40 ` syzbot
2024-07-30 4:28 ` [PATCH] wifi: plfxlc: remove assert for mac->lock Edward Adam Davis
2024-07-30 10:35 ` Kalle Valo [this message]
2024-07-30 11:46 ` Edward Adam Davis
2024-11-28 11:58 ` [syzbot] [wireless?] WARNING in plfxlc_mac_release syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cd39nhg.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=eadavis@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=srini.raju@purelifi.com \
--cc=syzbot+51a42f7c2e399392ea82@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.