All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Use card name rather than number in test names
Date: Fri, 12 Jul 2024 10:21:43 +0200	[thread overview]
Message-ID: <877cdrt3zc.wl-tiwai@suse.de> (raw)
In-Reply-To: <b3fdbb63-067b-4ff4-8fd8-1c2455a553a5@sirena.org.uk>

On Thu, 11 Jul 2024 18:19:25 +0200,
Mark Brown wrote:
> 
> On Thu, Jul 11, 2024 at 06:08:38PM +0200, Jaroslav Kysela wrote:
> > On 11. 07. 24 16:33, Mark Brown wrote:
> 
> > > Address this by replacing our use of card numbers with card names which are
> > > more likely to be stable across runs. We use the long name since in the
> 
> > I think that a combination of card number and card ID may be sufficient (and
> > a compromise). It's shorter and user-friendly. Additionally, a table may be
> > printed at the beginning of report with card number, card ID and long card
> > name for further processing and identification.
> 
> These don't help, the problem is that anything which includes the card
> number in the test name result is going to result in unstable test names
> depending on race conditions at boot.  There are automated systems that
> parse kselftest output generically, I'm not sure there's a great deal of
> enthusiasm for writing a custom parser for the ALSA selftests
> specifically.

OTOH, longname can be really ugly to read, and it can vary because it
often embeds address or irq numbers in the string.

If a general name is the goal, how about using shortname instead?

Or use id field, as Jaroslav suggested, but without the card number
suffix; then it's unique among multiple cards.


thanks,

Takashi

  reply	other threads:[~2024-07-12  8:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 14:33 [PATCH] kselftest/alsa: Use card name rather than number in test names Mark Brown
2024-07-11 16:08 ` Jaroslav Kysela
2024-07-11 16:19   ` Mark Brown
2024-07-12  8:21     ` Takashi Iwai [this message]
2024-07-12  9:20       ` Jaroslav Kysela
2024-07-12 13:00         ` Mark Brown
2024-07-12 16:25           ` Jaroslav Kysela
2024-07-12 18:19             ` Mark Brown
2024-07-13  6:46               ` Takashi Iwai
2024-07-15 13:18                 ` Mark Brown
2024-07-15 13:23                   ` Takashi Iwai
2024-07-15 17:31                     ` Mark Brown
2024-07-13  7:35               ` Jaroslav Kysela
2024-07-15 12:48                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cdrt3zc.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shuah@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.