All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Stefan Seyfried <stefan.seyfried@googlemail.com>
Subject: Re: [PATCH v1] irq: Set IRQF_COND_ONESHOT in request_irq()
Date: Thu, 11 Jul 2024 22:32:21 +0200	[thread overview]
Message-ID: <877cdru0tm.ffs@tglx> (raw)
In-Reply-To: <5800834.DvuYhMxLoT@rjwysocki.net>

On Thu, Jul 11 2024 at 12:20, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The callers of request_irq() don't care about IRQF_ONESHOT because they
> don't provide threaded handlers, but if they happen to share the IRQ
> with the ACPI SCI, which has a threaded handler and sets IRQF_ONESHOT,
> request_irq() will fail for them due to a flags mismatch.
>
> Address this by making request_irq() add IRQF_COND_ONESHOT to the flags
> passed to request_threaded_irq() for all of its callers.

In principle that should work. We'll see whether there are dragons
lurking :)

Thanks,

        tglx

  reply	other threads:[~2024-07-11 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 10:20 [PATCH v1] irq: Set IRQF_COND_ONESHOT in request_irq() Rafael J. Wysocki
2024-07-11 20:32 ` Thomas Gleixner [this message]
2024-07-11 21:04 ` [tip: irq/core] genirq: " tip-bot2 for Rafael J. Wysocki
2024-07-15 13:20 ` tip-bot2 for Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cdru0tm.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=stefan.seyfried@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.