All of lore.kernel.org
 help / color / mirror / Atom feed
From: Esben Haabendal <esben@geanix.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	 "Pratyush Yadav" <pratyush@kernel.org>,
	 "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	 "Vignesh Raghavendra" <vigneshr@ti.com>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	 "Rasmus Villemoes" <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH] mtd: spi-nor: macronix: workaround for device id re-use
Date: Mon, 03 Jun 2024 11:12:58 +0200	[thread overview]
Message-ID: <877cf6ie3p.fsf@geanix.com> (raw)
In-Reply-To: <D1Q8LSUGXEIH.1N6HH5514YIJV@kernel.org> (Michael Walle's message of "Mon, 03 Jun 2024 10:25:44 +0200")

"Michael Walle" <mwalle@kernel.org> writes:

> Hi,
>
>> > In that case, I'd rather see a new flag in .no_sfdp_flags
>> > to explicitly trigger the SFDP read. Then your new flash would only
>> > need this flag and doesn't require the shenanigans with the fixup,
>> > right?
>>
>> I fixup would still be required in order to enable 1-2-2 for MX25L3205D,
>> as it will fail the SFDP read, but actually does support 1-2-2.
>
> But you (probably) don't care and we also don't care for the
> additional speed. So, I'd rather drop that code that is just there
> for that ancient EoL flash.

Fine with me. Because you are right, I don't personally care. I don't
have any boards with the ancient 3205d part.

/Esben

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Esben Haabendal <esben@geanix.com>
To: "Michael Walle" <mwalle@kernel.org>
Cc: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
	 "Pratyush Yadav" <pratyush@kernel.org>,
	 "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	 "Vignesh Raghavendra" <vigneshr@ti.com>,
	 <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	 "Rasmus Villemoes" <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH] mtd: spi-nor: macronix: workaround for device id re-use
Date: Mon, 03 Jun 2024 11:12:58 +0200	[thread overview]
Message-ID: <877cf6ie3p.fsf@geanix.com> (raw)
In-Reply-To: <D1Q8LSUGXEIH.1N6HH5514YIJV@kernel.org> (Michael Walle's message of "Mon, 03 Jun 2024 10:25:44 +0200")

"Michael Walle" <mwalle@kernel.org> writes:

> Hi,
>
>> > In that case, I'd rather see a new flag in .no_sfdp_flags
>> > to explicitly trigger the SFDP read. Then your new flash would only
>> > need this flag and doesn't require the shenanigans with the fixup,
>> > right?
>>
>> I fixup would still be required in order to enable 1-2-2 for MX25L3205D,
>> as it will fail the SFDP read, but actually does support 1-2-2.
>
> But you (probably) don't care and we also don't care for the
> additional speed. So, I'd rather drop that code that is just there
> for that ancient EoL flash.

Fine with me. Because you are right, I don't personally care. I don't
have any boards with the ancient 3205d part.

/Esben

  reply	other threads:[~2024-06-03  9:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 10:48 [PATCH] mtd: spi-nor: macronix: workaround for device id re-use Esben Haabendal
2024-05-24 10:48 ` Esben Haabendal
2024-06-03  7:25 ` Michael Walle
2024-06-03  7:25   ` Michael Walle
2024-06-03  8:17   ` Esben Haabendal
2024-06-03  8:17     ` Esben Haabendal
2024-06-03  8:25     ` Michael Walle
2024-06-03  8:25       ` Michael Walle
2024-06-03  9:12       ` Esben Haabendal [this message]
2024-06-03  9:12         ` Esben Haabendal
2024-06-06 13:29   ` Tudor Ambarus
2024-06-06 13:29     ` Tudor Ambarus
2024-06-06 13:45     ` Michael Walle
2024-06-06 13:45       ` Michael Walle
2024-06-06 14:27       ` Tudor Ambarus
2024-06-06 14:27         ` Tudor Ambarus
2024-06-06 17:36         ` Esben Haabendal
2024-06-06 17:36           ` Esben Haabendal
2024-06-06 17:35       ` Esben Haabendal
2024-06-06 17:35         ` Esben Haabendal
2024-06-06 17:32     ` Esben Haabendal
2024-06-06 17:32       ` Esben Haabendal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cf6ie3p.fsf@geanix.com \
    --to=esben@geanix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=mwalle@kernel.org \
    --cc=pratyush@kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.