All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Yunseong Kim <yskelg@gmail.com>
Cc: skhan@linuxfoundation.org, Jinwoo Park <pmnxis@gmail.com>,
	Austin Kim <austindh.kim@gmail.com>,
	shjy180909@gmail.com, workflows@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3] Documentation: cve Korean translation
Date: Mon, 27 May 2024 08:55:33 -0600	[thread overview]
Message-ID: <877cffnw2i.fsf@meer.lwn.net> (raw)
In-Reply-To: <8880b0ec-9315-428e-b9c4-e578690d3c08@gmail.com>

Yunseong Kim <yskelg@gmail.com> writes:

> On 5/27/24 10:50 오후, Jonathan Corbet wrote:
>> Yunseong Kim <yskelg@gmail.com> writes:
>> 
>>>> 1) Why do I have three versions of it in my mailbox, sent over a period
>>>>    of 13 minutes?  What changed between the versions?
>>>
>>> Sorry, I forgot the name of the reviewer when I first sent the
>>> documentation content related patch version 2.
>> 
>> Which is fine, but...
>> 
>>>>    Normally, you want to wait for reviews to come in on one version
>>>>    before posting the next, and you should put a comment after the "---"
>>>>    line saying what changed.
>>>>
>>>> 2) When did this review from Jinwoo Park happen?  I was not copied on
>>>>    that.
>> 
>> You did not answer this question.  Reviews should generally be done in
>> public, but that does not seem to have happened here?
>
> Oops, sorry about that, Jonathan.
>
> Jinwoo Park sent me the review below, and I've updated some of ambiguous
> words in patch version 2.
>
> https://lore.kernel.org/linux-doc/57f0d90c-4cc6-4418-ab79-6ae026d8ae09@gmail.com/T/#t

It does look like the patch was reviewed, but no Reviewed-by tag was
offered.  *Never* apply a Reviewed-by tag that has not been explicitly
given to you.

Jinwoo, would you like to offer that tag for this patch?

Thanks,

jon

  reply	other threads:[~2024-05-27 14:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 10:30 [PATCH v3] Documentation: cve Korean translation yskelg
2024-05-27 12:43 ` Jonathan Corbet
2024-05-27 13:21   ` Yunseong Kim
2024-05-27 13:50     ` Jonathan Corbet
2024-05-27 14:43       ` Yunseong Kim
2024-05-27 14:55         ` Jonathan Corbet [this message]
2024-05-27 17:00           ` Jinwoo Park
2024-05-30  1:43 ` SeongJae Park
2024-05-30 11:46   ` Yunseong Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cffnw2i.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=austindh.kim@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmnxis@gmail.com \
    --cc=shjy180909@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    --cc=yskelg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.