Re: [PATCH 05/10] drm: move intel_lpe_audio.h under include/drm/intel

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 11 Apr 2024, Andi Shyti <andi.shyti@linux.intel.com> wrote:
> Hi Jani,
>
> On Wed, Apr 10, 2024 at 01:05:12PM +0300, Jani Nikula wrote:
>> Clean up the top level include/drm directory by grouping all the Intel
>> specific files under a common subdirectory.
>> 
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Cc: Dave Airlie <airlied@gmail.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Cc: Jaroslav Kysela <perex@perex.cz>
>> Cc: Takashi Iwai <tiwai@suse.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_hdmi.c      | 2 +-
>>  drivers/gpu/drm/i915/display/intel_lpe_audio.c | 2 +-
>>  include/drm/{ => intel}/intel_lpe_audio.h      | 0
>
> strange thing here is that we have two different
> intel_lpe_audio.h. Can't they be merged?

Not so strange. The one in i915 is internal to i915, and the one in
include/drm is shared with sound/x86/intel_hdmi_audio.c.

> And, perhaps, we could also think of dropping the intel_ prefix
> for the files inside drm/intel/.

This series was scripted, so I didn't go into manual stuff like that
(yet). :)

BR,
Jani.

>
> In any case,
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
>
> Thanks,
> Andi

-- 
Jani Nikula, Intel