From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/6] drm/modes: add drm_mode_print() to dump mode in drm_printer
Date: Mon, 08 Apr 2024 12:24:54 +0300 [thread overview]
Message-ID: <877ch8b40p.fsf@intel.com> (raw)
In-Reply-To: <ZhBG36AFIbFQ3dYk@intel.com>
On Fri, 05 Apr 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Apr 05, 2024 at 10:45:42AM +0200, Thomas Zimmermann wrote:
>> Am 07.03.24 um 21:39 schrieb Jani Nikula:
>> > +void drm_mode_print(struct drm_printer *p, const struct drm_display_mode *mode)
>>
>> Could this be a printf function with a trailing format string as final
>> argument? The printed mode could then be part of another string instead
>> of just at the end of it.
>
> All this seems pretty much redundant. We already have
> DRM_MODE_FMT/ARGS so people can include the mode in any
> kind of format string they want.
>
> I would just nuke drm_mode_print() and all its ilk and
> let people format things themselves.
Fair enough. Did just that in v2, for all the non-driver stuff anyway.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-04-08 9:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 20:39 [PATCH 0/6] drm: debug logging improvements Jani Nikula
2024-03-07 20:39 ` [PATCH 1/6] drm/modes: add drm_mode_print() to dump mode in drm_printer Jani Nikula
2024-04-05 8:45 ` Thomas Zimmermann
2024-04-05 18:45 ` Ville Syrjälä
2024-04-08 9:24 ` Jani Nikula [this message]
2024-03-07 20:39 ` [PATCH 2/6] drm/probe-helper: switch to drm device based logging Jani Nikula
2024-03-07 20:39 ` [PATCH 3/6] drm/modes: switch drm_mode_prune_invalid() to use struct drm_printer Jani Nikula
2024-03-07 20:39 ` [PATCH 4/6] drm/modes: switch to drm device based error logging Jani Nikula
2024-03-07 20:39 ` [PATCH 5/6] drm/sysfs: switch to drm device based logging Jani Nikula
2024-03-07 20:44 ` Jani Nikula
2024-03-07 20:39 ` [PATCH 6/6] drm/client: switch to drm device based logging, and more Jani Nikula
2024-03-07 20:47 ` Jani Nikula
2024-03-07 20:48 ` ✓ CI.Patch_applied: success for drm: debug logging improvements Patchwork
2024-03-07 20:48 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-07 20:49 ` ✓ CI.KUnit: success " Patchwork
2024-03-07 20:59 ` ✓ CI.Build: " Patchwork
2024-03-07 21:00 ` ✗ CI.Hooks: failure " Patchwork
2024-03-07 21:01 ` ✗ CI.checksparse: warning " Patchwork
2024-03-07 21:42 ` ✓ CI.BAT: success " Patchwork
2024-03-07 23:17 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-03-07 23:17 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-03-07 23:32 ` ✓ Fi.CI.BAT: success " Patchwork
2024-03-08 11:09 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-03-14 12:07 ` [PATCH 0/6] " Jani Nikula
2024-04-05 8:55 ` Thomas Zimmermann
2024-04-08 9:26 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ch8b40p.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.