From: Thomas Gleixner <tglx@linutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Marc Zyngier <maz@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Biju Das <biju.das.au@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/5] irqchip/renesas-rzg2l: Rename rzg2l_tint_eoi()
Date: Fri, 01 Mar 2024 15:41:20 +0100 [thread overview]
Message-ID: <877cimxbe7.ffs@tglx> (raw)
In-Reply-To: <CAMuHMdXZ0_O8-bjB9NyOKc3JKHjcE_w3wrhgQN3Ur7A8DvovKA@mail.gmail.com>
On Mon, Feb 12 2024 at 17:38, Geert Uytterhoeven wrote:
>> -static void rzg2l_tint_eoi(struct irq_data *d)
>> +static void rzg2l_clear_tint_int(struct rzg2l_irqc_priv *priv,
>> + unsigned int hwirq)
>> {
>> - unsigned int hw_irq = irqd_to_hwirq(d) - IRQC_TINT_START;
>> - struct rzg2l_irqc_priv *priv = irq_data_to_priv(d);
>> - u32 bit = BIT(hw_irq);
>> + u32 bit = BIT(hwirq - IRQC_TINT_START);
>> u32 reg;
>>
>> reg = readl_relaxed(priv->base + TSCR);
>> @@ -127,7 +126,7 @@ static void rzg2l_irqc_eoi(struct irq_data *d)
>> if (hw_irq >= IRQC_IRQ_START && hw_irq <= IRQC_IRQ_COUNT)
>> rzg2l_irq_eoi(d);
>> else if (hw_irq >= IRQC_TINT_START && hw_irq < IRQC_NUM_IRQ)
>> - rzg2l_tint_eoi(d);
>> + rzg2l_clear_tint_int(priv, hw_irq);
>
> Perhaps pass the tint number (i.e. "hw_irq - IRQC_TINT_START")
> instead?
No. You have to do that on all call sites then. There is another coming
in the next patch AFAICT.
Thanks,
tglx
next prev parent reply other threads:[~2024-03-01 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 11:37 [PATCH 0/5] Fix spurious TINT IRQ and enhancements Biju Das
2024-02-12 11:37 ` [PATCH 1/5] irqchip/renesas-rzg2l: Prevent IRQ HW race Biju Das
2024-03-01 14:39 ` Thomas Gleixner
2024-03-01 15:55 ` Biju Das
2024-02-12 11:37 ` [PATCH 2/5] irqchip/renesas-rzg2l: Rename rzg2l_tint_eoi() Biju Das
2024-02-12 16:38 ` Geert Uytterhoeven
2024-02-12 17:06 ` Biju Das
2024-03-01 14:41 ` Thomas Gleixner [this message]
2024-02-12 11:37 ` [PATCH 3/5] irqchip/renesas-rzg2l: Fix spurious TINT IRQ Biju Das
2024-03-01 15:36 ` Thomas Gleixner
2024-03-05 17:41 ` Biju Das
2024-02-12 11:37 ` [PATCH 4/5] irqchip/renesas-rzg2l: Use TIEN for enable/disable Biju Das
2024-03-01 14:15 ` Thomas Gleixner
2024-03-01 14:43 ` Biju Das
2024-02-12 11:37 ` [PATCH 5/5] irqchip/renesas-rzg2l: Simplify rzg2l_irqc_irq_{en,dis}able() Biju Das
2024-03-01 14:08 ` [PATCH 0/5] Fix spurious TINT IRQ and enhancements Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cimxbe7.ffs@tglx \
--to=tglx@linutronix.de \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.