From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD8F1C48BF8 for ; Mon, 19 Feb 2024 14:40:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc4oS-0005YG-3R; Mon, 19 Feb 2024 09:40:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc4oQ-0005XR-7b for qemu-devel@nongnu.org; Mon, 19 Feb 2024 09:40:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc4oO-0005Lu-Lw for qemu-devel@nongnu.org; Mon, 19 Feb 2024 09:40:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708353603; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S4TLxisse07JbzyB81c2xChYrNib89DkevZtfOFBm3g=; b=iprgxfA57DPyXsIb/OROgxVwBLPE+Xx4DpJCOFK4UOxvOZdPHemfjq9+/9vKftxzGjrZ8e pAWzz+Cm4tCOfU3XUT3btOxKpdnrFfCcF45G40C74H1TPuBnLc1PH4hWo4uKNCiFQZv5Ow 3JPi5ErU18XUDhR4nMbTStw2L7GRIRk= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-LC19aRCFPsqECSLsPDPBsQ-1; Mon, 19 Feb 2024 09:40:00 -0500 X-MC-Unique: LC19aRCFPsqECSLsPDPBsQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 172863830087; Mon, 19 Feb 2024 14:39:59 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D1EED1BDD1; Mon, 19 Feb 2024 14:39:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D3DB621E66D0; Mon, 19 Feb 2024 15:39:57 +0100 (CET) From: Markus Armbruster To: Sam Li Cc: qemu-devel@nongnu.org, dlemoal@kernel.org, Hanna Reitz , dmitry.fomichev@wdc.com, qemu-block@nongnu.org, Eric Blake , hare@suse.de, Kevin Wolf , stefanha@redhat.com Subject: Re: [PATCH v7 2/4] qcow2: add configurations for zoned format extension In-Reply-To: (Sam Li's message of "Mon, 19 Feb 2024 13:23:42 +0100") References: <20240122184830.40094-1-faithilikerun@gmail.com> <20240122184830.40094-3-faithilikerun@gmail.com> <87plwsfyyv.fsf@pond.sub.org> <87edd8fyme.fsf@pond.sub.org> Date: Mon, 19 Feb 2024 15:39:57 +0100 Message-ID: <877cj0jz5u.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sam Li writes: > Markus Armbruster =E4=BA=8E2024=E5=B9=B42=E6=9C=8819= =E6=97=A5=E5=91=A8=E4=B8=80 13:05=E5=86=99=E9=81=93=EF=BC=9A >> >> One more thing... >> >> Markus Armbruster writes: >> >> > I apologize for the delayed review. > > No problems. Thanks for reviewing! > >> > >> > Sam Li writes: >> > >> >> To configure the zoned format feature on the qcow2 driver, it >> >> requires settings as: the device size, zone model, zone size, >> >> zone capacity, number of conventional zones, limits on zone >> >> resources (max append bytes, max open zones, and max_active_zones). >> >> >> >> To create a qcow2 image with zoned format feature, use command like >> >> this: >> >> qemu-img create -f qcow2 zbc.qcow2 -o size=3D768M \ >> >> -o zone.size=3D64M -o zone.capacity=3D64M -o zone.conventional_zones= =3D0 \ >> >> -o zone.max_append_bytes=3D4096 -o zone.max_open_zones=3D6 \ >> >> -o zone.max_active_zones=3D8 -o zone.mode=3Dhost-managed >> >> >> >> Signed-off-by: Sam Li >> > >> > [...] >> > >> >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> >> index ca390c5700..e2e0ec21a5 100644 >> >> --- a/qapi/block-core.json >> >> +++ b/qapi/block-core.json >> >> @@ -5038,6 +5038,67 @@ >> >> { 'enum': 'Qcow2CompressionType', >> >> 'data': [ 'zlib', { 'name': 'zstd', 'if': 'CONFIG_ZSTD' } ] } >> >> >> >> +## >> >> +# @Qcow2ZoneModel: >> >> +# >> >> +# Zoned device model used in qcow2 image file >> >> +# >> >> +# @host-managed: The host-managed model only allows sequential write= over the >> >> +# device zones. >> >> +# >> >> +# Since 8.2 >> >> +## >> >> +{ 'enum': 'Qcow2ZoneModel', >> >> + 'data': [ 'host-managed'] } >> >> + >> >> +## >> >> +# @Qcow2ZoneHostManaged: >> >> +# >> >> +# The host-managed zone model. It only allows sequential writes. >> >> +# >> >> +# @size: Total number of bytes within zones. >> > >> > Default? > > It should be set by users. No default value provided. If it's unset > then it is zero and an error will be returned. If the user must provide @size, why is it optional then? >> > >> >> +# >> >> +# @capacity: The number of usable logical blocks within zones >> >> +# in bytes. A zone capacity is always smaller or equal to the >> >> +# zone size. >> > >> > Default? > > Same. > >> > >> >> +# @max-append-bytes: The maximal number of bytes of a zone >> >> +# append request that can be issued to the device. It must be >> >> +# 512-byte aligned and less than the zone capacity. >> > >> > Default? > > Same. > > For those values, I guess it could be set when users provide no > information and still want a workable emulated zoned block device. > >> > >> >> +# >> >> +# Since 8.2 >> >> +## >> >> +{ 'struct': 'Qcow2ZoneHostManaged', >> >> + 'data': { '*size': 'size', >> >> + '*capacity': 'size', >> >> + '*conventional-zones': 'uint32', >> >> + '*max-open-zones': 'uint32', >> >> + '*max-active-zones': 'uint32', >> >> + '*max-append-bytes': 'size' } } [...]