All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: peterx@redhat.com
Cc: qemu-devel@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>
Subject: Re: [PATCH] qapi/migration: Add missing tls-authz documentation
Date: Wed, 07 Feb 2024 07:07:58 +0100	[thread overview]
Message-ID: <877cjgx0w1.fsf@pond.sub.org> (raw)
In-Reply-To: <20240207032836.268183-1-peterx@redhat.com> (peterx@redhat.com's message of "Wed, 7 Feb 2024 11:28:36 +0800")

peterx@redhat.com writes:

> From: Peter Xu <peterx@redhat.com>
>
> As reported in Markus's recent enforcement series on qapi doc [1], we
> accidentally miss one entry for tls-authz.  Add it.  Then we can drop
> @MigrateSetParameters from documentation-exceptions safely later.
>
> [1] https://lore.kernel.org/r/20240205074709.3613229-1-armbru@redhat.com
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  qapi/migration.json | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 819708321d..f4c5f59e01 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -980,6 +980,10 @@
>  #     2.9) Previously (since 2.7), this was reported by omitting
>  #     tls-hostname instead.
>  #
> +# @tls-authz: ID of the 'authz' object subclass that provides access
> +#     control checking of the TLS x509 certificate distinguished name.
> +#     (Since 4.0)
> +#
>  # @max-bandwidth: to set maximum speed for migration.  maximum speed
>  #     in bytes per second.  (Since 2.8)
>  #

Reviewed-by: Markus Armbruster <armbru@redhat.com>

I propose I queue this right after [1] with the update to pragma.json
squashed in (appended), and the sentence "Then we can drop ... later"
dropped.

Thanks for your help!


diff --git a/qapi/pragma.json b/qapi/pragma.json
index 7ac05ccc26..6929ab776e 100644
--- a/qapi/pragma.json
+++ b/qapi/pragma.json
@@ -69,7 +69,6 @@
         'JSONType',
         'KeyValueKind',
         'MemoryDeviceInfoKind',
-        'MigrateSetParameters',
         'NetClientDriver',
         'ObjectType',
         'PciMemoryRegion',



  reply	other threads:[~2024-02-07  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  3:28 [PATCH] qapi/migration: Add missing tls-authz documentation peterx
2024-02-07  6:07 ` Markus Armbruster [this message]
2024-02-07  6:54   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cjgx0w1.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.