From: Fabiano Rosas <farosas@suse.de>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v1 1/5] tests/qtest: Add a helper to query the QEMU version
Date: Tue, 19 Dec 2023 13:59:20 -0300 [thread overview]
Message-ID: <877claf7rr.fsf@suse.de> (raw)
In-Reply-To: <16f68c89-dcf4-4da7-bfa1-c64db0754bca@redhat.com>
Thomas Huth <thuth@redhat.com> writes:
> On 07/12/2023 16.58, Fabiano Rosas wrote:
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> tests/qtest/libqtest.c | 24 ++++++++++++++++++++++++
>> tests/qtest/libqtest.h | 10 ++++++++++
>> 2 files changed, 34 insertions(+)
>>
>> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
>> index f33a210861..7cee68a834 100644
>> --- a/tests/qtest/libqtest.c
>> +++ b/tests/qtest/libqtest.c
>> @@ -337,6 +337,30 @@ void qtest_remove_abrt_handler(void *data)
>> }
>> }
>>
>> +void qtest_query_version(QTestState *who, int *major, int *minor, int *micro)
>
> I'd prefer "qts" instead of "who" ... but that's bikeshedding, so:
I'll change it. I need to send another version of this series anyway.
next prev parent reply other threads:[~2023-12-19 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 15:58 [PATCH v1 0/5] migration & CI: Add a CI job for migration compat testing Fabiano Rosas
2023-12-07 15:58 ` [PATCH v1 1/5] tests/qtest: Add a helper to query the QEMU version Fabiano Rosas
2023-12-19 14:32 ` Thomas Huth
2023-12-19 16:59 ` Fabiano Rosas [this message]
2023-12-07 15:58 ` [PATCH v1 2/5] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs Fabiano Rosas
2023-12-08 15:02 ` Fabiano Rosas
2023-12-19 14:36 ` Thomas Huth
2023-12-19 17:02 ` Fabiano Rosas
2023-12-07 15:58 ` [PATCH v1 3/5] tests/qtest/migration: Adapt tests to use " Fabiano Rosas
2023-12-07 15:58 ` [PATCH v1 4/5] ci: Add a migration compatibility test job Fabiano Rosas
2023-12-07 15:58 ` [PATCH v1 5/5] [NOT FOR MERGE] compat hack until 8.2 is out Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877claf7rr.fsf@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.