From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] intel_iommu: Fix shadow local variables on "size"
Date: Fri, 29 Sep 2023 08:47:05 +0200 [thread overview]
Message-ID: <877co9iihi.fsf@pond.sub.org> (raw)
In-Reply-To: <20230922160410.138786-1-peterx@redhat.com> (Peter Xu's message of "Fri, 22 Sep 2023 12:04:10 -0400")
Peter Xu <peterx@redhat.com> writes:
> This patch fixes the warning of shadowed local variable:
>
> ../hw/i386/intel_iommu.c: In function ‘vtd_address_space_unmap’:
> ../hw/i386/intel_iommu.c:3773:18: warning: declaration of ‘size’ shadows a previous local [-Wshadow=compatible-local]
> 3773 | uint64_t size = mask + 1;
> | ^~~~
> ../hw/i386/intel_iommu.c:3747:12: note: shadowed declaration is here
> 3747 | hwaddr size, remain;
> | ^~~~
>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Queued, thanks!
prev parent reply other threads:[~2023-09-29 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 16:04 [PATCH] intel_iommu: Fix shadow local variables on "size" Peter Xu
2023-09-22 18:17 ` Philippe Mathieu-Daudé
2023-09-22 21:15 ` Michael S. Tsirkin
2023-09-29 6:47 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877co9iihi.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.