From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] m68k: Silence -Wshadow=local warnings in the m68k code
Date: Tue, 26 Sep 2023 15:15:41 +0200 [thread overview]
Message-ID: <877codqdmq.fsf@pond.sub.org> (raw)
In-Reply-To: <a20d141c-8fe4-08bc-5276-a5a6c3d08d0e@redhat.com> (Thomas Huth's message of "Tue, 26 Sep 2023 14:59:18 +0200")
Thomas Huth <thuth@redhat.com> writes:
> On 26/09/2023 14.19, Markus Armbruster wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>>
>>> Rename the innermost variables to make the code compile
>>> without warnings when using -Wshadow=local.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>
>> Clashes with patches from Philippe and Laurent:
>>
>> [PATCH v2 05/22] target/m68k: Clean up local variable shadowing
>> [PATCH] disas/m68k: clean up local variable shadowing
>>
>> You guys figure out how to combine them, please :)
>
> Ok, then never mind about my patch.
> Anyway, it's getting confusing what has already been fixed and what not ... could you please pick up all patches that are available so far and send a pull request for them?
I'm collecting at https://repo.or.cz/qemu/armbru.git in branch
shadow-next. I'll send a new summary shortly. I intend to send a PR,
but first I need to collect R-bys and drop patches that aren't ready, if
any.
prev parent reply other threads:[~2023-09-26 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 18:56 [PATCH] m68k: Silence -Wshadow=local warnings in the m68k code Thomas Huth
2023-09-26 7:43 ` Laurent Vivier
2023-09-26 12:19 ` Markus Armbruster
2023-09-26 12:59 ` Thomas Huth
2023-09-26 13:15 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877codqdmq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.