From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5D9FC7EE2E for ; Tue, 13 Jun 2023 07:38:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 60A04823; Tue, 13 Jun 2023 09:37:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 60A04823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686641882; bh=xHt6kGMbJ3iZt2ZiML4uEdu0Iq5ALkDqc7rv8tfqGf8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=SDuVZUNxPaG5Om5olfITgz62HqEXfZRaBmiYmTfBAcGSvMAqUdFFfJ8Mn/mNO1O1Z Ni8FCYjDoOjHcCCokQdFvai/H8mbNCMfRVu/SVSmbh6eCNWR3RFALf/iEqL4RXLYL4 Z0Lt1K+GMgCD5PNK2jAETQPqV7Rq32TcH/NUWsj8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6A45EF80132; Tue, 13 Jun 2023 09:36:47 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D0861F80149; Tue, 13 Jun 2023 09:36:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2EE66F80149; Tue, 13 Jun 2023 09:36:42 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 75163F80130 for ; Tue, 13 Jun 2023 09:36:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 75163F80130 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t6M9c4a9; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Hg56atq0 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5981E21F89; Tue, 13 Jun 2023 07:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686641796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fARwb/FOWC2J0IiNmo1ULMamrop8hmzZFfpzdyoCU/w=; b=t6M9c4a9ynt2QnblBDTEeXcbL5TbH+GJaFmhsxIVUIXmfDOlDnJ7Q/BK9eU+j6Klpr+7nw csDs23DWMVBjkP2q0HriN8VjMonS4SY/lGRzjpWn4uv2fLmy7PXIuIGUkQXpQgFX/1fpVS U2aPyyvBnK0GzepwuydyZH62QPL7vKc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686641796; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fARwb/FOWC2J0IiNmo1ULMamrop8hmzZFfpzdyoCU/w=; b=Hg56atq0EVLED9Hh+7DNyJdiD+EQGbDEx3vKkZTa8dxznXxZ5AKI7x1NsqQReFeMA0Xd1/ 8vQemszzlpj/uIBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2B7A713345; Tue, 13 Jun 2023 07:36:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hdzECYQciGQ7GAAAMHmgww (envelope-from ); Tue, 13 Jun 2023 07:36:36 +0000 Date: Tue, 13 Jun 2023 09:36:34 +0200 Message-ID: <877cs7g6f1.wl-tiwai@suse.de> From: Takashi Iwai To: Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda: Use maple tree register cache In-Reply-To: <87v8fua1qm.wl-tiwai@suse.de> References: <20230609-alsa-hda-maple-v1-1-a2b725c8b8f5@kernel.org> <87v8fua1qm.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: J2CFTUTOTFR3RX3IJLRETTUMMLYU2H5M X-Message-ID-Hash: J2CFTUTOTFR3RX3IJLRETTUMMLYU2H5M X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 11 Jun 2023 09:37:21 +0200, Takashi Iwai wrote: > > On Sat, 10 Jun 2023 16:26:37 +0200, > Mark Brown wrote: > > > > HDA can only support single register read and write operations so does not > > benefit from block writes. This means it gets no benefit from using the > > rbtree register cache over the maple tree register cache so convert it to > > use maple trees instead, it is more modern. > > > > Signed-off-by: Mark Brown > > Thanks, applied to for-next branch. Now I noticed errors like snd_hda_codec_realtek hdaudioC0D0: Unable to sync register 0x2f0009. -5 and it turned out that the error comes from this patch. This is an error from regache_sync_val(), and it indicates that the synced register is write-only; regcache_maple_sync() tries to sync all cached values no matter whether it's writable or not, then hitting this. I'll submit a fix patch. thanks, Takashi