From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F47EC7EE29 for ; Tue, 6 Jun 2023 15:47:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3A6A0820; Tue, 6 Jun 2023 17:46:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3A6A0820 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1686066428; bh=MmBPz+5yzRJ2o1otSV/Q1cvgVyIfYEqeiXArd3iiFpc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=O8Lqc78OgiFif/wpoEmeGfGw/6vlGrp/BDh5b+vsZdl/ABN0XmiAlDwNYkB9kioig QDyNcqyPA4tG4V2rAGQO18WoCUb4R0V+I+JqFmddgVkSaldX/HWRZjU58yIpu3QakT +w2NRxUrjaopC6cklCvDGWDSer/7Ihqm/ax/MeOk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0164DF8016C; Tue, 6 Jun 2023 17:45:55 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7C4C4F800C8; Tue, 6 Jun 2023 17:45:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2E388F80199; Tue, 6 Jun 2023 17:45:51 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D6BB8F800ED for ; Tue, 6 Jun 2023 17:45:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D6BB8F800ED Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MLYden4P; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ULrI3S/c Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 470E0219EB; Tue, 6 Jun 2023 15:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686066348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=MLYden4PysPezLPwrVom0z5h5s95w2GwZow9JKezerxq2xCF7YQMZPeqFUAi+KVCizPfc2 hZwhajDMwcbvl4NjtmuFaPmJCxOu73+5Vj1SA50ECcPISp3DHfkI3oSGOQE0zMK5VmUrTn RZ4MD2roba8ViLEiKxjUaLuSeoVhHLQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686066348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zIRZuOqdc1wbgXJlnttVCJmlBEYYHdfUu9cmmFB8VxI=; b=ULrI3S/cmX13oY3UQO9BrjqTNsERUYy1MVZRjyqCIv68tBuQqOtw+WTqDUu36RxKtqu8w3 M4kWjrbq1vmbK/Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1FDA313776; Tue, 6 Jun 2023 15:45:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yprpBqxUf2TmJwAAMHmgww (envelope-from ); Tue, 06 Jun 2023 15:45:48 +0000 Date: Tue, 06 Jun 2023 17:45:47 +0200 Message-ID: <877csgfvbo.wl-tiwai@suse.de> From: Takashi Iwai To: Chris Chiu Cc: perex@perex.cz, tiwai@suse.com, sbinding@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4 amplifiers instead of 2 on a HP platform In-Reply-To: <20230606145747.135966-1-chris.chiu@canonical.com> References: <20230606145747.135966-1-chris.chiu@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 6MADDPDWH5ZFAVAXTRUB6XYIW4UUHMSO X-Message-ID-Hash: 6MADDPDWH5ZFAVAXTRUB6XYIW4UUHMSO X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 06 Jun 2023 16:57:47 +0200, Chris Chiu wrote: > > In the commit 7bb62340951a ("ALSA: hda/realtek: fix speaker, mute/micmute > LEDs not work on a HP platform"), speakers and LEDs are fixed but only 2 > CS35L41 amplifiers on SPI bus connected to Realtek codec are enabled. Need > the ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED to get all amplifiers working. > > Signed-off-by: Chris Chiu Applied now with the manual addition of Fixes tag. At the next time, please don't forget to put the proper Fixes tag if you know the commit to fix. thanks, Takashi