From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AB7C7EE23 for ; Mon, 5 Jun 2023 11:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231839AbjFELl0 (ORCPT ); Mon, 5 Jun 2023 07:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230189AbjFELlZ (ORCPT ); Mon, 5 Jun 2023 07:41:25 -0400 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 734629C; Mon, 5 Jun 2023 04:41:24 -0700 (PDT) Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4QZWsF3WQBz9sqj; Mon, 5 Jun 2023 13:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1685965281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7z/UoffUh1YYEy028D6jPchnsvqTeKCwT3Ef8OGYOM=; b=DRB3tloLf6ynRPZH2ivFGP2IpNHHWfCZtzG3piH8zTBeCGxvSJaTtZOf3zImsXo1hQpndm i9GSi/cFs4wKW91ao/5i03z6w2ps1YC04MvjF/2CZDxLHJfjaOPqR+yAaiiCpBbKQw1PGD /+dhOeLHOayY0Ve69W8SeCkZ8QRgSkno8Cb2YrYWJaDOxPr7g/dFV+pLK4Moa0OJX1BnUQ iTWvsGPFbjVTg6X19RamKwJlshnhA1mrwxkmUngrPsZr0kojmKNvyDNg7lXc8uPCkh8SPi euy2vDk88fM6qqKA5vMjpjvl2LTXui1dMoqGlEVFCqaY5Uot7RzpvbsCP2MEEQ== References: <20230527132747.83196-1-frank@oltmanns.dev> <87mt1jbf18.fsf@oltmanns.dev> <4831731.31r3eYUQgx@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= , Maxime Ripard Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Andre Przywara , Chen-Yu Tsai , Icenowy Zheng , Michael Turquette , Rob Herring , Samuel Holland , Stephen Boyd Subject: Re: [RFC PATCH 0/3] clk: sunxi-ng: Optimize rate selection for NKM clocks In-reply-to: Date: Mon, 05 Jun 2023 13:41:17 +0200 Message-ID: <877csi9lwi.fsf@oltmanns.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QZWsF3WQBz9sqj Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Jernej, hi Maxime, On 2023-06-02 at 09:34:03 +0200, Maxime Ripard wrote: > [[PGP Signed Part:Undecided]] > On Thu, Jun 01, 2023 at 09:41:30PM +0200, Jernej =C5=A0krabec wrote: >> Dne =C4=8Detrtek, 01. junij 2023 ob 07:16:45 CEST je Frank Oltmanns napi= sal(a): >> > Re: Why speed up factor calculation? >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > I'm not aware that the current implementation of calculating n, k, and= m >> > poses a bottleneck in any situation. Again, while going through the >> > code, I wondered why not save a few CPU cycles by precalculating the >> > meaningful combinations. In my opinion, it does not have any side >> > effects, so we might as well do it. (There is of course the side effect >> > of using a higher rate, but this is unrelated to precalculation as I >> > could as well employ a rate comparison that only allows lower rates, or >> > only optionally higher rates.) >> > >> > > Clocks in general are very regression-prone, so I'd rather be a bit >> > > conservative there, and "if it ain't broke, don't fix it". >> > >> > Sure, I get that. >> > >> > As I stated in my cover letter: >> > "The motivation for these proposed changes lies in the current behavior >> > of rate selection for NKM clocks, which doesn't observe the >> > CLK_SET_RATE_PARENT flag. I.e. it does not select a different rate for >> > the parent clock to find the optimal rate." >> > >> > I thought that this required this optimization to be implemented, but = by >> > now, I'm no longer sure. I'll probably continue investigating different >> > paths for CLK_SET_RATE_PARENT for NKM clocks and follow up with new >> > findings. >> >> Let's leave out any optimizations that are not apparently needed. Most c= lock >> rates are set only once at boot and others, like video clocks, not that = often, >> so a suboptimal code speed doesn't hurt currently. > > I'm not even sure we can make that assumption for video clocks. We might > for a panel, but for a more "dynamic" output like HDMI all bets are off > and depending on the monitor, the user settings and the userspace stack > we can definitely expect the video clock to change quite frequently. Thank you both for your valuable feedback! The goal I head in mind was adjusting pll-video0's clock when setting DCLK on Allwinner A64. And you're both right, I got sidetracked by premature optimizations. As I wrote elsewhere in this thread, I will submit a patchset for the original goal and we can discuss potential needs for optimization there. Thanks, Frank > > Maxime > > [[End of PGP Signed Part]] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A1E0C7EE23 for ; Mon, 5 Jun 2023 11:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-reply-to:Subject:Cc:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2sDUBZqrSaQInm53psQFwmlD1LVCE2+vX8hPZa0QxY8=; b=zY0GMcNmyfT60OJCl9ZnOJ3LpS 7GrHCSUcK7velAFDs4g8cL3R244SiwycvY5UaiDQUmScvKuDPRTH0Jixm++3DdygPm9EvcWQy8Cl6 5QjshljMhk5fvga/wMl3pjRNA+zRf0KHCJtzOEVZ6UVAJMFDwigl3vj15v2Jcy84T1NKAaXiVy0sZ q2mkgVL6JhVPOXy/VUaCmqMJsYRmiDi90juS1Ym1L4HhfHid7sdARuBSTfYMjePiMxLxquwjomzna WMsAlBTM5E7rb18pvR9Sj0Dd7BpKIfZ3BvFPHBocFeL8y+iAgrVXwoeIGs3F6uKQ0xJFydi63X1Xw tXYDgXPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q68aV-00FJkY-1g; Mon, 05 Jun 2023 11:41:27 +0000 Received: from mout-p-201.mailbox.org ([80.241.56.171]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q68aS-00FJk0-1O for linux-arm-kernel@lists.infradead.org; Mon, 05 Jun 2023 11:41:25 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4QZWsF3WQBz9sqj; Mon, 5 Jun 2023 13:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oltmanns.dev; s=MBO0001; t=1685965281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P7z/UoffUh1YYEy028D6jPchnsvqTeKCwT3Ef8OGYOM=; b=DRB3tloLf6ynRPZH2ivFGP2IpNHHWfCZtzG3piH8zTBeCGxvSJaTtZOf3zImsXo1hQpndm i9GSi/cFs4wKW91ao/5i03z6w2ps1YC04MvjF/2CZDxLHJfjaOPqR+yAaiiCpBbKQw1PGD /+dhOeLHOayY0Ve69W8SeCkZ8QRgSkno8Cb2YrYWJaDOxPr7g/dFV+pLK4Moa0OJX1BnUQ iTWvsGPFbjVTg6X19RamKwJlshnhA1mrwxkmUngrPsZr0kojmKNvyDNg7lXc8uPCkh8SPi euy2vDk88fM6qqKA5vMjpjvl2LTXui1dMoqGlEVFCqaY5Uot7RzpvbsCP2MEEQ== References: <20230527132747.83196-1-frank@oltmanns.dev> <87mt1jbf18.fsf@oltmanns.dev> <4831731.31r3eYUQgx@jernej-laptop> From: Frank Oltmanns To: Jernej =?utf-8?Q?=C5=A0krabec?= , Maxime Ripard Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Andre Przywara , Chen-Yu Tsai , Icenowy Zheng , Michael Turquette , Rob Herring , Samuel Holland , Stephen Boyd Subject: Re: [RFC PATCH 0/3] clk: sunxi-ng: Optimize rate selection for NKM clocks In-reply-to: Date: Mon, 05 Jun 2023 13:41:17 +0200 Message-ID: <877csi9lwi.fsf@oltmanns.dev> MIME-Version: 1.0 X-Rspamd-Queue-Id: 4QZWsF3WQBz9sqj X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230605_044124_637228_D467ED45 X-CRM114-Status: GOOD ( 24.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmVybmVqLApoaSBNYXhpbWUsCgpPbiAyMDIzLTA2LTAyIGF0IDA5OjM0OjAzICswMjAwLCBN YXhpbWUgUmlwYXJkIDxtcmlwYXJkQGtlcm5lbC5vcmc+IHdyb3RlOgo+IFtbUEdQIFNpZ25lZCBQ YXJ0OlVuZGVjaWRlZF1dCj4gT24gVGh1LCBKdW4gMDEsIDIwMjMgYXQgMDk6NDE6MzBQTSArMDIw MCwgSmVybmVqIMWga3JhYmVjIHdyb3RlOgo+PiBEbmUgxI1ldHJ0ZWssIDAxLiBqdW5paiAyMDIz IG9iIDA3OjE2OjQ1IENFU1QgamUgRnJhbmsgT2x0bWFubnMgbmFwaXNhbChhKToKPj4gPiBSZTog V2h5IHNwZWVkIHVwIGZhY3RvciBjYWxjdWxhdGlvbj8KPj4gPiA9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KPj4gPiBJJ20gbm90IGF3YXJlIHRoYXQgdGhlIGN1cnJlbnQgaW1w bGVtZW50YXRpb24gb2YgY2FsY3VsYXRpbmcgbiwgaywgYW5kIG0KPj4gPiBwb3NlcyBhIGJvdHRs ZW5lY2sgaW4gYW55IHNpdHVhdGlvbi4gQWdhaW4sIHdoaWxlIGdvaW5nIHRocm91Z2ggdGhlCj4+ ID4gY29kZSwgSSB3b25kZXJlZCB3aHkgbm90IHNhdmUgYSBmZXcgQ1BVIGN5Y2xlcyBieSBwcmVj YWxjdWxhdGluZyB0aGUKPj4gPiBtZWFuaW5nZnVsIGNvbWJpbmF0aW9ucy4gSW4gbXkgb3Bpbmlv biwgaXQgZG9lcyBub3QgaGF2ZSBhbnkgc2lkZQo+PiA+IGVmZmVjdHMsIHNvIHdlIG1pZ2h0IGFz IHdlbGwgZG8gaXQuIChUaGVyZSBpcyBvZiBjb3Vyc2UgdGhlIHNpZGUgZWZmZWN0Cj4+ID4gb2Yg dXNpbmcgYSBoaWdoZXIgcmF0ZSwgYnV0IHRoaXMgaXMgdW5yZWxhdGVkIHRvIHByZWNhbGN1bGF0 aW9uIGFzIEkKPj4gPiBjb3VsZCBhcyB3ZWxsIGVtcGxveSBhIHJhdGUgY29tcGFyaXNvbiB0aGF0 IG9ubHkgYWxsb3dzIGxvd2VyIHJhdGVzLCBvcgo+PiA+IG9ubHkgb3B0aW9uYWxseSBoaWdoZXIg cmF0ZXMuKQo+PiA+Cj4+ID4gPiBDbG9ja3MgaW4gZ2VuZXJhbCBhcmUgdmVyeSByZWdyZXNzaW9u LXByb25lLCBzbyBJJ2QgcmF0aGVyIGJlIGEgYml0Cj4+ID4gPiBjb25zZXJ2YXRpdmUgdGhlcmUs IGFuZCAiaWYgaXQgYWluJ3QgYnJva2UsIGRvbid0IGZpeCBpdCIuCj4+ID4KPj4gPiBTdXJlLCBJ IGdldCB0aGF0Lgo+PiA+Cj4+ID4gQXMgSSBzdGF0ZWQgaW4gbXkgY292ZXIgbGV0dGVyOgo+PiA+ ICJUaGUgbW90aXZhdGlvbiBmb3IgdGhlc2UgcHJvcG9zZWQgY2hhbmdlcyBsaWVzIGluIHRoZSBj dXJyZW50IGJlaGF2aW9yCj4+ID4gb2YgcmF0ZSBzZWxlY3Rpb24gZm9yIE5LTSBjbG9ja3MsIHdo aWNoIGRvZXNuJ3Qgb2JzZXJ2ZSB0aGUKPj4gPiBDTEtfU0VUX1JBVEVfUEFSRU5UIGZsYWcuIEku ZS4gaXQgZG9lcyBub3Qgc2VsZWN0IGEgZGlmZmVyZW50IHJhdGUgZm9yCj4+ID4gdGhlIHBhcmVu dCBjbG9jayB0byBmaW5kIHRoZSBvcHRpbWFsIHJhdGUuIgo+PiA+Cj4+ID4gSSB0aG91Z2h0IHRo YXQgdGhpcyByZXF1aXJlZCB0aGlzIG9wdGltaXphdGlvbiB0byBiZSBpbXBsZW1lbnRlZCwgYnV0 IGJ5Cj4+ID4gbm93LCBJJ20gbm8gbG9uZ2VyIHN1cmUuIEknbGwgcHJvYmFibHkgY29udGludWUg aW52ZXN0aWdhdGluZyBkaWZmZXJlbnQKPj4gPiBwYXRocyBmb3IgQ0xLX1NFVF9SQVRFX1BBUkVO VCBmb3IgTktNIGNsb2NrcyBhbmQgZm9sbG93IHVwIHdpdGggbmV3Cj4+ID4gZmluZGluZ3MuCj4+ Cj4+IExldCdzIGxlYXZlIG91dCBhbnkgb3B0aW1pemF0aW9ucyB0aGF0IGFyZSBub3QgYXBwYXJl bnRseSBuZWVkZWQuIE1vc3QgY2xvY2sKPj4gcmF0ZXMgYXJlIHNldCBvbmx5IG9uY2UgYXQgYm9v dCBhbmQgb3RoZXJzLCBsaWtlIHZpZGVvIGNsb2Nrcywgbm90IHRoYXQgb2Z0ZW4sCj4+IHNvIGEg c3Vib3B0aW1hbCBjb2RlIHNwZWVkIGRvZXNuJ3QgaHVydCBjdXJyZW50bHkuCj4KPiBJJ20gbm90 IGV2ZW4gc3VyZSB3ZSBjYW4gbWFrZSB0aGF0IGFzc3VtcHRpb24gZm9yIHZpZGVvIGNsb2Nrcy4g V2UgbWlnaHQKPiBmb3IgYSBwYW5lbCwgYnV0IGZvciBhIG1vcmUgImR5bmFtaWMiIG91dHB1dCBs aWtlIEhETUkgYWxsIGJldHMgYXJlIG9mZgo+IGFuZCBkZXBlbmRpbmcgb24gdGhlIG1vbml0b3Is IHRoZSB1c2VyIHNldHRpbmdzIGFuZCB0aGUgdXNlcnNwYWNlIHN0YWNrCj4gd2UgY2FuIGRlZmlu aXRlbHkgZXhwZWN0IHRoZSB2aWRlbyBjbG9jayB0byBjaGFuZ2UgcXVpdGUgZnJlcXVlbnRseS4K ClRoYW5rIHlvdSBib3RoIGZvciB5b3VyIHZhbHVhYmxlIGZlZWRiYWNrIQoKVGhlIGdvYWwgSSBo ZWFkIGluIG1pbmQgd2FzIGFkanVzdGluZyBwbGwtdmlkZW8wJ3MgY2xvY2sgd2hlbiBzZXR0aW5n CkRDTEsgb24gQWxsd2lubmVyIEE2NC4gQW5kIHlvdSdyZSBib3RoIHJpZ2h0LCBJIGdvdCBzaWRl dHJhY2tlZCBieQpwcmVtYXR1cmUgb3B0aW1pemF0aW9ucy4KCkFzIEkgd3JvdGUgZWxzZXdoZXJl IGluIHRoaXMgdGhyZWFkLCBJIHdpbGwgc3VibWl0IGEgcGF0Y2hzZXQgZm9yIHRoZQpvcmlnaW5h bCBnb2FsIGFuZCB3ZSBjYW4gZGlzY3VzcyBwb3RlbnRpYWwgbmVlZHMgZm9yIG9wdGltaXphdGlv biB0aGVyZS4KClRoYW5rcywKICBGcmFuawoKPgo+IE1heGltZQo+Cj4gW1tFbmQgb2YgUEdQIFNp Z25lZCBQYXJ0XV0KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK