From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F34BC77B73 for ; Sun, 21 May 2023 06:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229770AbjEUGXQ (ORCPT ); Sun, 21 May 2023 02:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230180AbjEUGXJ (ORCPT ); Sun, 21 May 2023 02:23:09 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C745E46 for ; Sat, 20 May 2023 23:22:57 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA8B61FD7B; Sun, 21 May 2023 06:22:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684650175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K6WgYX3+4JPXyBRLNRcc7FPcPkiactSsV+yrns5CXJE=; b=TGUdGGahIbBCogql31lXFRA6YrTnwQSlHD54hPFsY4TYsDIPkXbluOdUCM9XMjGBytaeUb R8s2s/B2dUs1qrBgNBf/Jy2qQQmJlR7SEybcMSdf+eFhD3cntspoaYt6gxIAakfQMsIj7D BjO4SwGAgqv7y/vj8euF/BBkGlDHnbk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684650175; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K6WgYX3+4JPXyBRLNRcc7FPcPkiactSsV+yrns5CXJE=; b=54YhbEIjghbLU3NQPpZQWy2nLYySJHNyPAHSGXxIo4NgDpphFJ1lY0P8CYayHo18vlviu9 50Fn23+SeCMqTDCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B521713425; Sun, 21 May 2023 06:22:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id k4hWK7+4aWRlCwAAMHmgww (envelope-from ); Sun, 21 May 2023 06:22:55 +0000 Date: Sun, 21 May 2023 08:22:56 +0200 Message-ID: <877ct2yzi7.wl-tiwai@suse.de> From: Takashi Iwai To: Adam Stylinski Cc: Takashi Iwai , perex@perex.cz, linux-kernel@vger.kernel.org Subject: Re: ca0132 patches In-Reply-To: References: <87a5xzz3lf.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 May 2023 04:29:45 +0200, Adam Stylinski wrote: > > Sorry, mutt's being insane uncooperative. Here's the format-patch attached. > > On Sat, May 20, 2023 at 11:21 AM Adam Stylinski wrote: > > > > Mutt + SMTP + Gmail are acting up and I had to head out. I'll get this sent out tonight, though. Did you want me to cc the mailing list too? > > > > On Sat, May 20, 2023, 10:27 AM Adam Stylinski wrote: > >> > >> Correct. A format-patch output is coming soon, I'm just waiting for a > >> proper clone to finish. > >> > >> On Sat, May 20, 2023 at 6:42 AM Takashi Iwai wrote: > >> > > >> > On Fri, 19 May 2023 05:53:09 +0200, > >> > Xian Wang wrote: > >> > > > >> > > On 18/05/2023 20:02, Adam Stylinski wrote: > >> > > > Hello, > >> > > > > >> > > > I noticed you patched in a quirk in basically the same place I am for > >> > > > a different EVGA board. This quirk is needed for me as well but it > >> > > > would seem the bugzilla and mailing lists are ignored. I was hoping > >> > > > maybe I could draw your attention to this? > >> > > > > >> > > > https://bugzilla.kernel.org/show_bug.cgi?id=67071 > >> > > > > >> > > > I suffer a similar issue (namely surround is disabled without enabling > >> > > > this quirk). I still have some temperamental behavior with the quirk > >> > > > in place (the port mapping doesn't always seem consistent boot to > >> > > > boot, often needing several reboots before all channels are working). > >> > > > I'm not certain if this is a quirk of loading the firmware or what. > >> > > > At the very least, not having to patch this locally every kernel > >> > > > update would be nice. I'm CC'ing the maintainer who signed off on the > >> > > > patch as well, really hoping to get some attention on this. > >> > > > >> > > Hi Adam, > >> > > > >> > > Unfortunately I haven't experienced the flakiness of surround sound > >> > > mentioned in the bug. The channel mapping seems correct and is > >> > > consistent from boot to boot. > >> > > > >> > > For not patching locally every time there is a new kernel, are you > >> > > open to submit that one-line patch up? > >> > > >> > So you need only the addition of > >> > SND_PCI_QUIRK(0x3842, 0x104b, "EVGA X299 Dark", QUIRK_R3DI) > >> > ? > >> > > >> > If so, I can submit a oneliner from my side, too. But it's still > >> > better to be submitted from the person who actually tested the patch, > >> > of course. > >> > > >> > > >> > Takashi > From fd1ff1aff3a70716b4d6d99a89934aea5d718cad Mon Sep 17 00:00:00 2001 > From: Adam Stylinski > Date: Sat, 20 May 2023 10:31:54 -0400 > Subject: [PATCH] ALSA: hda/ca0132: add quirk for EVGA X299 DARK > > This quirk is necessary for surround and other DSP effects to work > with the onboard ca0132 based audio chipset for the EVGA X299 dark > mainboard. > > Signed-off-by: Adam Stylinski Could you rather submit to alsa-devel ML (plus Cc to LKML)? thanks, Takashi > > --- > sound/pci/hda/patch_ca0132.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c > index 099722ebaed8..748a3c40966e 100644 > --- a/sound/pci/hda/patch_ca0132.c > +++ b/sound/pci/hda/patch_ca0132.c > @@ -1306,6 +1306,7 @@ static const struct snd_pci_quirk ca0132_quirks[] = { > SND_PCI_QUIRK(0x1458, 0xA026, "Gigabyte G1.Sniper Z97", QUIRK_R3DI), > SND_PCI_QUIRK(0x1458, 0xA036, "Gigabyte GA-Z170X-Gaming 7", QUIRK_R3DI), > SND_PCI_QUIRK(0x3842, 0x1038, "EVGA X99 Classified", QUIRK_R3DI), > + SND_PCI_QUIRK(0x3842, 0x104b, "EVGA X299 Dark", QUIRK_R3DI), > SND_PCI_QUIRK(0x3842, 0x1055, "EVGA Z390 DARK", QUIRK_R3DI), > SND_PCI_QUIRK(0x1102, 0x0013, "Recon3D", QUIRK_R3D), > SND_PCI_QUIRK(0x1102, 0x0018, "Recon3D", QUIRK_R3D), > -- > 2.40.1 >