Re: [PATCH] chardev: report the handshake error

[Markus Armbruster <armbru@redhat.com>]

marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This can help to debug connection issues.
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=2196182
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  chardev/char-socket.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index 8c58532171..e8e3a743d5 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -742,8 +742,12 @@ static void tcp_chr_websock_handshake(QIOTask *task, gpointer user_data)
>  {
>      Chardev *chr = user_data;
>      SocketChardev *s = user_data;
> +    Error *err = NULL;
>  
> -    if (qio_task_propagate_error(task, NULL)) {
> +    if (qio_task_propagate_error(task, &err)) {
> +        error_reportf_err(err,
> +                          "websock handshake of character device %s failed: ",
> +                          chr->label);

Code smell: reports an error without failing the function.

Should it be a warning instead?

>          tcp_chr_disconnect(chr);
>      } else {
>          if (s->do_telnetopt) {
> @@ -778,8 +782,12 @@ static void tcp_chr_tls_handshake(QIOTask *task,
>  {
>      Chardev *chr = user_data;
>      SocketChardev *s = user_data;
> +    Error *err = NULL;
>  
> -    if (qio_task_propagate_error(task, NULL)) {
> +    if (qio_task_propagate_error(task, &err)) {
> +        error_reportf_err(err,
> +                          "TLS handshake of character device %s failed: ",
> +                          chr->label);
>          tcp_chr_disconnect(chr);
>      } else {
>          if (s->is_websock) {

Likewise.