From: Fabiano Rosas <farosas@suse.de>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Claudio Fontana <cfontana@suse.de>,
qemu-arm@nongnu.org
Subject: Re: [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled
Date: Wed, 22 Mar 2023 14:45:34 -0300 [thread overview]
Message-ID: <877cv8smrl.fsf@suse.de> (raw)
In-Reply-To: <3d67c765-20fc-9ae9-1dfe-753f4ef16263@linaro.org>
Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> On 22/3/23 15:29, Philippe Mathieu-Daudé wrote:
>> Fix when building QEMU configured with --disable-tcg:
>>
>> Undefined symbols for architecture arm64:
>> "_arm_v7m_get_sp_ptr", referenced from:
>> _m_sysreg_get in target_arm_gdbstub.c.o
>> "_arm_v7m_mrs_control", referenced from:
>> _arm_gdb_get_m_systemreg in target_arm_gdbstub.c.o
>> "_pauth_ptr_mask", referenced from:
>> _aarch64_gdb_get_pauth_reg in target_arm_gdbstub64.c.o
>> ld: symbol(s) not found for architecture arm64
>> clang: error: linker command failed with exit code 1 (use -v to see invocation)
>
> Beside having the non-TCG configs tested in CI, (I think) we can avoid
> such breakage by moving the TCG-specific declarations from
> target/arm/internals.h to some target/arm/tcg/tcg-internals.h header.
> (target/arm/internals.h is 1400+ LoC anyway). Worth it?
I think it would be worth it. That still leaves the issue of these small
functions that are semantically related to what is being emulated but
don't need any TCG-specific symbols. It would be nice if we had a
default approach for where to put them. Without going back to sticking
everything in helper.c, of course. =)
next prev parent reply other threads:[~2023-03-22 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 14:29 [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled Philippe Mathieu-Daudé
2023-03-22 14:29 ` [PATCH-for-8.0 1/2] target/arm/gdbstub: Restrict aarch64_gdb_get_pauth_reg() to CONFIG_TCG Philippe Mathieu-Daudé
2023-03-22 15:15 ` Richard Henderson
2023-03-28 13:34 ` Philippe Mathieu-Daudé
2023-03-22 14:29 ` [PATCH-for-8.0 2/2] target/arm/gdbstub: Only advertise M-profile features if TCG available Philippe Mathieu-Daudé
2023-03-22 15:13 ` Richard Henderson
2023-03-22 16:21 ` Alex Bennée
2023-03-22 14:32 ` [PATCH-for-8.0 0/2] target/arm/gdbstub: Fix builds when TCG is disabled Philippe Mathieu-Daudé
2023-03-22 17:45 ` Fabiano Rosas [this message]
2023-03-28 9:54 ` Peter Maydell
2023-03-28 13:20 ` Philippe Mathieu-Daudé
2023-03-28 13:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cv8smrl.fsf@suse.de \
--to=farosas@suse.de \
--cc=cfontana@suse.de \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.