From: Kalle Valo <kvalo@kernel.org>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Yan-Hsuan Chuang <tony0620emma@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] drivers: net: realtek: fix memory leak in rtw_usb_probe
Date: Wed, 08 Mar 2023 17:07:26 +0200 [thread overview]
Message-ID: <877cvrp9ht.fsf@kernel.org> (raw)
In-Reply-To: <20230308142028.481504-1-dzm91@hust.edu.cn> (Dongliang Mu's message of "Wed, 8 Mar 2023 22:20:28 +0800")
+ linux-wireless
Dongliang Mu <dzm91@hust.edu.cn> writes:
> drivers/net/wireless/realtek/rtw88/usb.c:876 rtw_usb_probe()
> warn: 'hw' from ieee80211_alloc_hw() not released on lines: 811
>
> Fix this by modifying return to a goto statement.
>
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
> drivers/net/wireless/realtek/rtw88/usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You forgot to CC linux-wireless and the title should be:
wifi: rtw88: fix memory leak in rtw_usb_probe()
Please fix these and submit v2.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
parent reply other threads:[~2023-03-08 15:08 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230308142028.481504-1-dzm91@hust.edu.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cvrp9ht.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=dzm91@hust.edu.cn \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.