From: Cornelia Huck <cohuck@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH 0/3] Cleanup for PCI transitional common cfg
Date: Mon, 27 Feb 2023 09:59:07 +0100 [thread overview]
Message-ID: <877cw35vs4.fsf@redhat.com> (raw)
In-Reply-To: <20230225181618-mutt-send-email-mst@kernel.org>
On Sat, Feb 25 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Sun, Feb 26, 2023 at 12:29:58AM +0200, Parav Pandit wrote:
>> Legacy interface PCI Device layout description has following issues.
>>
>> 1. repeated 'structure' word
>> 2. virtio header was defined the 0.9.5 spec. It is referred with
>> different keywards in this section with multiple different words
>> as (a) virtio header, (b) general headers, (c) legacy configuration
>> structure, (d) virtio common configuration structure and
>> (e) other fields.
>> 3. Driver and device requirements listing is intermixed.
>> 4. spelling error of structure
>> 5. Legacy interface common configuration requirements are not adjacent
>> to 1.x comm
>>
>> Hence, this short series overcomes above issues.
>
> Looking at the patchset so far I'm inclined to say - leave
> legacy well alone. This is not an improvement.
>
> Gratituis changes for trivial benefit have a cost - people have to
> re-read spec this to see what changed. Making things significantly
> easier for new readers would make it worth it. As it stands - this is
> not worth it.
I think I agree.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
prev parent reply other threads:[~2023-02-27 8:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 22:29 [PATCH 0/3] Cleanup for PCI transitional common cfg Parav Pandit
2023-02-25 22:29 ` [virtio-dev] " Parav Pandit
2023-02-25 22:29 ` [PATCH 1/3] transport-pci: Improve PCI legacy device layout description Parav Pandit
2023-02-25 22:29 ` [virtio-dev] " Parav Pandit
2023-02-25 23:08 ` Michael S. Tsirkin
2023-02-25 23:08 ` [virtio-dev] " Michael S. Tsirkin
2023-02-27 3:02 ` Parav Pandit
2023-02-27 3:02 ` [virtio-dev] " Parav Pandit
2023-02-27 7:34 ` Michael S. Tsirkin
2023-02-27 7:34 ` [virtio-dev] " Michael S. Tsirkin
2023-02-25 22:30 ` [PATCH 2/3] transport-pci: Split notes of PCI Device Layout Parav Pandit
2023-02-25 22:30 ` [virtio-dev] " Parav Pandit
2023-02-25 23:15 ` Michael S. Tsirkin
2023-02-25 23:15 ` [virtio-dev] " Michael S. Tsirkin
2023-02-27 3:05 ` Parav Pandit
2023-02-27 3:05 ` [virtio-dev] " Parav Pandit
2023-02-27 7:35 ` [virtio-dev] " Michael S. Tsirkin
2023-02-25 22:30 ` [PATCH 3/3] transport-pci: Relocate common config legacy interface Parav Pandit
2023-02-25 22:30 ` [virtio-dev] " Parav Pandit
2023-02-25 23:16 ` Michael S. Tsirkin
2023-02-25 23:16 ` [virtio-dev] " Michael S. Tsirkin
2023-02-27 3:07 ` Parav Pandit
2023-02-27 3:07 ` [virtio-dev] " Parav Pandit
2023-02-25 23:17 ` [PATCH 0/3] Cleanup for PCI transitional common cfg Michael S. Tsirkin
2023-02-25 23:17 ` [virtio-dev] " Michael S. Tsirkin
2023-02-27 8:59 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cw35vs4.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.