From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F32C05027 for ; Tue, 14 Feb 2023 08:57:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRr7U-0004RW-Uw; Tue, 14 Feb 2023 03:57:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRr7T-0004R6-Pn for qemu-devel@nongnu.org; Tue, 14 Feb 2023 03:56:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRr7S-0002OY-7j for qemu-devel@nongnu.org; Tue, 14 Feb 2023 03:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676365017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hshzM/kPkr6Ta85vQoEp8C5yZH8U7lgR/XvMGRqOOnA=; b=b76qijf60ci1qzgXuVGZi//AVjF/FSf/d25lBj8FXnpawLU/ZbSi6/IxRunCKY14rSuTrm 1Vm65xudl4F2VFq1C/DlaJBhlpuFWnXD/9RDN8u0BF8djNMGDd1Ryk4zlXAidcLo/7NIon AOe5XLcco+KuStZ2s4iCwWOf3qHdMRw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-257-clOKKzGNN8uQQlOLfIkJ6A-1; Tue, 14 Feb 2023 03:56:52 -0500 X-MC-Unique: clOKKzGNN8uQQlOLfIkJ6A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C4A6882821; Tue, 14 Feb 2023 08:56:51 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48D6A51E5; Tue, 14 Feb 2023 08:56:51 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1EF2C21E6A1F; Tue, 14 Feb 2023 09:56:50 +0100 (CET) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com, eduardo@habkost.net, berrange@redhat.com, pbonzini@redhat.com, marcel.apfelbaum@gmail.com, mst@redhat.com, den-plotnikov@yandex-team.ru, antonkuchin@yandex-team.ru Subject: Re: [PATCH v4 15/16] qapi: add HOTPLUG_STATE event References: <20230213140103.1518173-1-vsementsov@yandex-team.ru> <20230213140103.1518173-16-vsementsov@yandex-team.ru> <7fc9712a-136a-d296-4a7b-194195f3b699@linaro.org> Date: Tue, 14 Feb 2023 09:56:50 +0100 In-Reply-To: <7fc9712a-136a-d296-4a7b-194195f3b699@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 13 Feb 2023 15:10:29 +0100") Message-ID: <877cwkoca5.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > On 13/2/23 15:01, Vladimir Sementsov-Ogievskiy wrote: >> For PCIe and SHPC hotplug it's important to track led indicators, >> especially the power led. Add an event that helps. >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> qapi/qdev.json | 175 ++++++++++++++++++++++++++++++++ >> include/hw/hotplug.h | 12 +++ >> include/hw/pci/pci.h | 3 + >> include/hw/pci/pci_bridge.h | 2 + >> include/hw/pci/pcie.h | 2 + >> include/hw/pci/shpc.h | 2 + >> include/monitor/qdev.h | 5 + >> hw/core/hotplug.c | 13 +++ >> hw/pci-bridge/pci_bridge_dev.c | 14 +++ >> hw/pci-bridge/pcie_pci_bridge.c | 1 + >> hw/pci/pcie.c | 79 ++++++++++++++ >> hw/pci/pcie_port.c | 1 + >> hw/pci/shpc.c | 102 ++++++++++++++++++- >> softmmu/qdev-monitor.c | 39 +++++++ >> 14 files changed, 445 insertions(+), 5 deletions(-) > > -ETOOBIG Can't see how this could be split sensibly: it's a single query/event pair. If you can, let us know.