From: Kalle Valo <kvalo@kernel.org>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Johnny Kim <johnny.kim@atmel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chris Park <chris.park@atmel.com>,
Rachel Kim <rachel.kim@atmel.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit()
Date: Thu, 17 Nov 2022 12:09:47 +0200 [thread overview]
Message-ID: <877cztsxhw.fsf@kernel.org> (raw)
In-Reply-To: <1668657419-29240-1-git-send-email-zhangchangzhong@huawei.com> (Zhang Changzhong's message of "Thu, 17 Nov 2022 11:56:58 +0800")
Zhang Changzhong <zhangchangzhong@huawei.com> writes:
> The wilc_mac_xmit() returns NETDEV_TX_OK without freeing skb, add
> dev_kfree_skb() to fix it.
>
> Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Same as in your other patch, have you tested this is on a real device?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-11-17 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 3:56 [PATCH wireless] wilc1000: fix potential memory leak in wilc_mac_xmit() Zhang Changzhong
2022-11-17 10:09 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cztsxhw.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ajay.kathat@microchip.com \
--cc=chris.park@atmel.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=rachel.kim@atmel.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.