From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45037C433FE for ; Wed, 2 Nov 2022 12:00:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 35D70167A; Wed, 2 Nov 2022 12:59:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 35D70167A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1667390444; bh=WKvGfL69rOy6KXKNG8xSW3V/n2gls/who/ez/iS0WJk=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lkTUlnSxl9M8IIN40zSZvMDZfzgAxqu0CP+Fgq2sOFpZs7Pdp/UCDRikJFSVc8eOb B45gTFiAnTTlwcFW6SPtxQt0IVg6zNcCVeiv9AyKJOx3Cfr0LuAp/PK2dcaFCI0Q5C rTpQbemQE+vIzPCMHCGEXK/5/QHQ8Iy5DMcnjaWE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C3F9FF80254; Wed, 2 Nov 2022 12:59:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A427F8026D; Wed, 2 Nov 2022 12:59:53 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A9316F80155 for ; Wed, 2 Nov 2022 12:59:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A9316F80155 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="fl/Zmwpq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="9jNRbGyg" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B04961F8BE; Wed, 2 Nov 2022 11:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667390389; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f0PFgiF0xvXPwx6dkzs7Ix4/erN5LNBcjdIUg2uMQSQ=; b=fl/Zmwpqn90PuTlbFllHMuPlizC3agS+OUvarFZ7fPa4fLgVIDEGEsw1Nuy47S8nLkwOKs UMbE9gvn1szxddyn51hvFfC5/P23cCb2D8j8htqqdXwun5kvkvJw4xpHm8n4oTan5JDLSG eHfpjWR7c6UmGyXB3FkjTJXB6bjc+y0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667390389; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f0PFgiF0xvXPwx6dkzs7Ix4/erN5LNBcjdIUg2uMQSQ=; b=9jNRbGygEHfaLytjpWcWDTmNf2sJAeXXoYXMeMaGvmj7bo7GtmBSUMpt1K0uAc2aw1OVpU ZQPHpRANWPjIG7BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9C31513AE0; Wed, 2 Nov 2022 11:59:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NTMoJbVbYmNmBgAAMHmgww (envelope-from ); Wed, 02 Nov 2022 11:59:49 +0000 Date: Wed, 02 Nov 2022 12:59:49 +0100 Message-ID: <877d0dtvm2.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: usb-audio: Fix regression with Dell Dock jack detection In-Reply-To: <9b0c4f2d-1856-a80d-ad9d-9b34436fdc1c@perex.cz> References: <20221102113404.11291-1-tiwai@suse.de> <9b0c4f2d-1856-a80d-ad9d-9b34436fdc1c@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 02 Nov 2022 12:53:48 +0100, Jaroslav Kysela wrote: > > On 02. 11. 22 12:34, Takashi Iwai wrote: > > The recent commit added Jack controls to Dell Dock, but it added with > > iface = SNDRV_CTL_ELEM_IFACE_CARD. Unfortunately this doesn't match > > with the changes in user-space UCM profile, which expects iface = > > SNDRV_CTL_ELEM_IFACE_MIXER as default. This mismatch resulted in the > > non-working profile, and the Dell Dock is gone on pipewire / > > PulseAudio after the kernel update. > > > > Fix the regression by adjusting the iface of the new ctl elements to > > *_MIXER. > > Hi Takashi, > > UCM expects SNDRV_CTL_ELEM_IFACE_CARD for jacks by default. Which > change do you refer? I would drop this patch. It's about ucm2/USB-Audio/Dell/WD15-Dock-HiFi.conf, the JackControl entries. For example, JackControl "Headphone Jack" expects the mixer element. The bad thing is that the complete card entry disappears because of inconsistency. If you modify the entry as JackControl "name='Headphone Jack',iface=CARD" it would work. But the fact that other JackControl stuff works, it's better to align the USB-audio with IFACE_MIXER, I guess. Takashi