From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACFA4C38A2D for ; Tue, 25 Oct 2022 13:18:26 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CDA281F07; Tue, 25 Oct 2022 15:17:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CDA281F07 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666703904; bh=uMpd/TqEGMzMNYi40SklosIJQaH6ALWlYO+N+mzuwqo=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DvrPSWtyMc1Nit5X3YKA774+VQqjzo2+ddwubIrcujSYLn+Wrp/SHFa+011pKSq5H ut6uvTTf/bz3birYT2RgGNaPP7tIiW+7snXAv3rwd5iLCwzZLExO8we1+x5EBC0lmR pkZ1RMzI6885Gd7nkexnBpYRgTugelZjC3/vaIQo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7E331F8042F; Tue, 25 Oct 2022 15:17:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 45577F80431; Tue, 25 Oct 2022 15:17:32 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0BABF80100 for ; Tue, 25 Oct 2022 15:17:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0BABF80100 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="vR/ERnDC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="2SkjBjps" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E25671F38C; Tue, 25 Oct 2022 13:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666703845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J+arnLUOjo5ZmX86eZOgv0maNE0nmXyovqICunRlfp0=; b=vR/ERnDCix69JHYBVMcsqXuQoqbeG8DBXWHAIiYprRHh6q/jHk5UmcEKgUZ8psLpV7VFZm nP5sM4GJ5A3n6rZ9cs8i8Xqq+tYiGCKqsaABYQZ2QouX+CHJqF6QBz+gZImla5AfZ/wNFZ Vd7HbHwbeOP9rZ7AawWq2Toh1/IVz7k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666703845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J+arnLUOjo5ZmX86eZOgv0maNE0nmXyovqICunRlfp0=; b=2SkjBjps9LLNefZj3ve25lU3lGaDkoLJeEFYLDvr5ld2IYT2eWYPDj0pv77DE3FWWlPqQa Rg5Vb30SRu7yyLBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9B881134CA; Tue, 25 Oct 2022 13:17:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BTTmJOXhV2PoNgAAMHmgww (envelope-from ); Tue, 25 Oct 2022 13:17:25 +0000 Date: Tue, 25 Oct 2022 15:17:25 +0200 Message-ID: <877d0oqbyy.wl-tiwai@suse.de> From: Takashi Iwai To: "Jason A. Donenfeld" Subject: Re: [PATCH v2] ALSA: rme9652: use explicitly signed char In-Reply-To: References: <202210250456.vKv5zoLb-lkp@intel.com> <20221025000313.546261-1-Jason@zx2c4.com> <87bkq0s9rw.wl-tiwai@suse.de> <87fsfcqdbx.wl-tiwai@suse.de> <87czagqc8k.wl-tiwai@suse.de> <87a65kqc4e.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 25 Oct 2022 15:14:54 +0200, Jason A. Donenfeld wrote: > > On Tue, Oct 25, 2022 at 3:14 PM Takashi Iwai wrote: > > > > On Tue, 25 Oct 2022 15:11:39 +0200, > > Takashi Iwai wrote: > > > > > > On Tue, 25 Oct 2022 14:54:54 +0200, > > > Jason A. Donenfeld wrote: > > > > > > > > On Tue, Oct 25, 2022 at 2:48 PM Takashi Iwai wrote: > > > > > > > > > > On Tue, 25 Oct 2022 14:08:29 +0200, > > > > > Jason A. Donenfeld wrote: > > > > > > > > > > > > On Tue, Oct 25, 2022 at 08:21:55AM +0200, Takashi Iwai wrote: > > > > > > > On Tue, 25 Oct 2022 02:03:13 +0200, > > > > > > > Jason A. Donenfeld wrote: > > > > > > > > > > > > > > > > With char becoming unsigned by default, and with `char` alone being > > > > > > > > ambiguous and based on architecture, signed chars need to be marked > > > > > > > > explicitly as such. This fixes warnings like: > > > > > > > > > > > > > > > > sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned > > > > > > > > sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)' > > > > > > > > sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned > > > > > > > > > > > > > > > > Cc: Jaroslav Kysela > > > > > > > > Cc: Takashi Iwai > > > > > > > > Cc: alsa-devel@alsa-project.org > > > > > > > > Signed-off-by: Jason A. Donenfeld > > > > > > > > > > > > > > Applied now. Thanks! > > > > > > > > > > > > Thanks. For this and the other patch, applied for 6.1 or 6.2? > > > > > > > > > > I applied for 6.2. Was it an action that has to be fixed for 6.1? > > > > > If so, I still can shuffle. > > > > > > > > Well, this is code that's broken currently on ARM platforms, for > > > > example, where char is already unsigned. So it's arguably a fix for > > > > 6.1. > > > > > > Fair enough, I'll apply for 6.1, then. > > > > ... and in that case, it deserves for Cc-to-stable, IMO, as it's a fix > > to be done for older kernels, too. Then it'd be clearly a 6.1 > > material. > > Fine by me if you want to add that (for this and the other patch). OK, done. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA433C04A95 for ; Tue, 25 Oct 2022 13:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbiJYNRc (ORCPT ); Tue, 25 Oct 2022 09:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232638AbiJYNR2 (ORCPT ); Tue, 25 Oct 2022 09:17:28 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BE83DCAF4 for ; Tue, 25 Oct 2022 06:17:27 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E25671F38C; Tue, 25 Oct 2022 13:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1666703845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J+arnLUOjo5ZmX86eZOgv0maNE0nmXyovqICunRlfp0=; b=vR/ERnDCix69JHYBVMcsqXuQoqbeG8DBXWHAIiYprRHh6q/jHk5UmcEKgUZ8psLpV7VFZm nP5sM4GJ5A3n6rZ9cs8i8Xqq+tYiGCKqsaABYQZ2QouX+CHJqF6QBz+gZImla5AfZ/wNFZ Vd7HbHwbeOP9rZ7AawWq2Toh1/IVz7k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1666703845; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=J+arnLUOjo5ZmX86eZOgv0maNE0nmXyovqICunRlfp0=; b=2SkjBjps9LLNefZj3ve25lU3lGaDkoLJeEFYLDvr5ld2IYT2eWYPDj0pv77DE3FWWlPqQa Rg5Vb30SRu7yyLBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9B881134CA; Tue, 25 Oct 2022 13:17:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BTTmJOXhV2PoNgAAMHmgww (envelope-from ); Tue, 25 Oct 2022 13:17:25 +0000 Date: Tue, 25 Oct 2022 15:17:25 +0200 Message-ID: <877d0oqbyy.wl-tiwai@suse.de> From: Takashi Iwai To: "Jason A. Donenfeld" Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ALSA: rme9652: use explicitly signed char In-Reply-To: References: <202210250456.vKv5zoLb-lkp@intel.com> <20221025000313.546261-1-Jason@zx2c4.com> <87bkq0s9rw.wl-tiwai@suse.de> <87fsfcqdbx.wl-tiwai@suse.de> <87czagqc8k.wl-tiwai@suse.de> <87a65kqc4e.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Oct 2022 15:14:54 +0200, Jason A. Donenfeld wrote: > > On Tue, Oct 25, 2022 at 3:14 PM Takashi Iwai wrote: > > > > On Tue, 25 Oct 2022 15:11:39 +0200, > > Takashi Iwai wrote: > > > > > > On Tue, 25 Oct 2022 14:54:54 +0200, > > > Jason A. Donenfeld wrote: > > > > > > > > On Tue, Oct 25, 2022 at 2:48 PM Takashi Iwai wrote: > > > > > > > > > > On Tue, 25 Oct 2022 14:08:29 +0200, > > > > > Jason A. Donenfeld wrote: > > > > > > > > > > > > On Tue, Oct 25, 2022 at 08:21:55AM +0200, Takashi Iwai wrote: > > > > > > > On Tue, 25 Oct 2022 02:03:13 +0200, > > > > > > > Jason A. Donenfeld wrote: > > > > > > > > > > > > > > > > With char becoming unsigned by default, and with `char` alone being > > > > > > > > ambiguous and based on architecture, signed chars need to be marked > > > > > > > > explicitly as such. This fixes warnings like: > > > > > > > > > > > > > > > > sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned > > > > > > > > sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)' > > > > > > > > sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned > > > > > > > > > > > > > > > > Cc: Jaroslav Kysela > > > > > > > > Cc: Takashi Iwai > > > > > > > > Cc: alsa-devel@alsa-project.org > > > > > > > > Signed-off-by: Jason A. Donenfeld > > > > > > > > > > > > > > Applied now. Thanks! > > > > > > > > > > > > Thanks. For this and the other patch, applied for 6.1 or 6.2? > > > > > > > > > > I applied for 6.2. Was it an action that has to be fixed for 6.1? > > > > > If so, I still can shuffle. > > > > > > > > Well, this is code that's broken currently on ARM platforms, for > > > > example, where char is already unsigned. So it's arguably a fix for > > > > 6.1. > > > > > > Fair enough, I'll apply for 6.1, then. > > > > ... and in that case, it deserves for Cc-to-stable, IMO, as it's a fix > > to be done for older kernels, too. Then it'd be clearly a 6.1 > > material. > > Fine by me if you want to add that (for this and the other patch). OK, done. Takashi