From: Markus Armbruster <armbru@redhat.com>
To: victortoso@redhat.com
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [PULL 00/10] QAPI patches patches for 2022-09-07
Date: Fri, 30 Sep 2022 17:29:31 +0200 [thread overview]
Message-ID: <877d1k519g.fsf@pond.sub.org> (raw)
In-Reply-To: <877d1z7fvg.fsf@pond.sub.org> (Markus Armbruster's message of "Mon, 19 Sep 2022 13:39:15 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> Gentle reminder, Victor :)
>
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Markus Armbruster <armbru@redhat.com> writes:
>>
>>> Kevin Wolf <kwolf@redhat.com> writes:
>>>
>>>> Am 07.09.2022 um 17:03 hat Markus Armbruster geschrieben:
>>>>> The following changes since commit 946e9bccf12f2bcc3ca471b820738fb22d14fc80:
[...]
>>>>> qapi: fix examples of blockdev-add with qcow2
>>>>
>>>> NACK, this patch is wrong.
>>>>
>>>> 'file' is a required member (defined in BlockdevOptionsGenericFormat),
>>>> removing it makes the example invalid. 'data-file' is only an additional
>>>> optional member to be used for external data files (i.e. when the guest
>>>> data is kept separate from the metadata in the .qcow2 file).
>>>
>>> I'll respin with #8 dropped. Thank you!
>>
>> Too late, it's already merged.
>>
>> Victor, could you fix on top? Or would you like me to revert the patch?
Revert posted:
Subject: [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"
Date: Fri, 30 Sep 2022 17:26:34 +0200
Message-Id: <20220930152634.774907-1-armbru@redhat.com>
next prev parent reply other threads:[~2022-09-30 15:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 15:03 [PULL 00/10] QAPI patches patches for 2022-09-07 Markus Armbruster
2022-09-07 15:03 ` [PULL 01/10] qapi: fix example of query-ballon command Markus Armbruster
2022-09-07 15:03 ` [PULL 02/10] qapi: fix example of query-vnc command Markus Armbruster
2022-09-07 15:03 ` [PULL 03/10] qapi: fix example of query-dump-guest-memory-capability command Markus Armbruster
2022-09-07 15:03 ` [PULL 04/10] qapi: fix example of BLOCK_JOB_READY event Markus Armbruster
2022-09-07 15:03 ` [PULL 05/10] qapi: fix example of NIC_RX_FILTER_CHANGED event Markus Armbruster
2022-09-07 15:03 ` [PULL 06/10] qapi: fix example of DEVICE_UNPLUG_GUEST_ERROR event Markus Armbruster
2022-09-07 15:03 ` [PULL 07/10] qapi: fix example of MEM_UNPLUG_ERROR event Markus Armbruster
2022-09-07 15:03 ` [PULL 08/10] qapi: fix examples of blockdev-add with qcow2 Markus Armbruster
2022-09-07 15:03 ` [PULL 09/10] qapi: fix example of query-hotpluggable-cpus command Markus Armbruster
2022-09-07 15:03 ` [PULL 10/10] qapi: fix examples of events missing timestamp Markus Armbruster
2022-09-07 18:43 ` [PULL 00/10] QAPI patches patches for 2022-09-07 Stefan Hajnoczi
2022-09-08 10:58 ` Kevin Wolf
2022-09-08 11:33 ` Markus Armbruster
2022-09-08 11:39 ` Markus Armbruster
2022-09-19 11:39 ` Markus Armbruster
2022-09-30 15:29 ` Markus Armbruster [this message]
2022-09-30 17:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d1k519g.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.