From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AABCC54EE9 for ; Sat, 17 Sep 2022 09:59:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CCB06610FA; Sat, 17 Sep 2022 09:59:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CCB06610FA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id djdxFpm-LT29; Sat, 17 Sep 2022 09:59:57 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 4C13960D4E; Sat, 17 Sep 2022 09:59:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4C13960D4E Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 8C3C31BF23C for ; Sat, 17 Sep 2022 09:59:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6784160D4E for ; Sat, 17 Sep 2022 09:59:54 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6784160D4E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QpVz6LTYFgtR for ; Sat, 17 Sep 2022 09:59:53 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3C60B60C07 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3C60B60C07 for ; Sat, 17 Sep 2022 09:59:52 +0000 (UTC) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id 4253E100005; Sat, 17 Sep 2022 09:59:51 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1oZUc1-009CZX-Vu; Sat, 17 Sep 2022 11:59:49 +0200 From: Peter Korsgaard To: Thomas Petazzoni via buildroot References: <20220821190153.233016-1-thomas.petazzoni@bootlin.com> Date: Sat, 17 Sep 2022 11:59:49 +0200 In-Reply-To: <20220821190153.233016-1-thomas.petazzoni@bootlin.com> (Thomas Petazzoni via buildroot's message of "Sun, 21 Aug 2022 21:01:52 +0200") Message-ID: <877d2248yy.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] package/Makefile.in: only error out when no C library is configured when building X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Thomas" == Thomas Petazzoni via buildroot writes: > Commit fda53f0791f5657d41735a40a29df3c8d0e8ae79 ("package/Makefile.in: > add detection for the lack of C library") added an $(error ...) > message when no C library is available for the currently selected > architecture. > However, this error message pops up not just when building, so for > example, the command: > make BR2_HAVE_DOT_CONFIG=y VARS=%_LICENSE printvars > no longer works (this command is used by the pkg-stats script). > We restore a functional behavior by doing the check only when > BR_BUILDING=y. > Signed-off-by: Thomas Petazzoni Committed to 2022.05.x and 2022.02.x, thanks. -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot